Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split aero and integrant into two separate parts. #34

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

bryanmikaelian
Copy link
Collaborator

@bryanmikaelian bryanmikaelian commented Aug 29, 2024

The integrant + aero config map is very confusing. It took me at least a week to decrypt what was done and how things even functioned. This was originally copy-pasta from kit. It makes sense for that framework but not for our needs.

Instead, we are just following the suggestions in this blog post and decoupling the two.

  1. aero loads system.edn, interpreting env vars when appropriate
  2. We merge that with a settings map filled with ig/refs
  3. system/start gets called, calling ig/prep and ig/init under the hood.

Drop all ig/ref stuff in an aero config
@bryanmikaelian bryanmikaelian merged commit 742fd8f into main Aug 29, 2024
5 checks passed
@bryanmikaelian bryanmikaelian deleted the split-integrant-aero branch August 29, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant