Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mfa_token env and mfa-token-command #420

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

mheiges
Copy link

@mheiges mheiges commented Dec 11, 2023

add support for mfa_token env var and --mfa-token-command arg

fixes #174

I am unable to get --stdin to correctly accept a username and password when using symantec auth, even with the stock 2.9.1a0, so that part of the issue request is not supported.

mfa tokens seem too transient to me to be suitable for an authfile, so that's also not supported.

@pdecat pdecat self-requested a review December 13, 2023 11:05
@pdecat pdecat self-assigned this Dec 13, 2023
@pdecat pdecat added enhancement python Pull requests that update Python code labels Dec 13, 2023
Copy link
Collaborator

@pdecat pdecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot test it but looks good overall! One minor comment about the help message.

aws_adfs/login.py Outdated Show resolved Hide resolved
@pdecat pdecat merged commit 1ea9bc1 into venth:master Dec 15, 2023
16 checks passed
@pdecat
Copy link
Collaborator

pdecat commented Dec 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MFA Token from STDIN or ENV or AUTHFILE
2 participants