Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hausa translation #1404

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add Hausa translation #1404

merged 1 commit into from
Aug 21, 2024

Conversation

sandakersmann
Copy link
Contributor

Translated with ChatGPT-4o

@idrassi
Copy link
Member

idrassi commented Aug 21, 2024

I wasn't familiar with the Hausa language before. I checked, and since it is supported by Windows as a language pack, it makes sense to add it to VeraCrypt.
Thank you for your contribution!

@idrassi idrassi merged commit ce9537f into veracrypt:master Aug 21, 2024
1 check passed
@Jertzukka
Copy link
Contributor

Why is there +150 occurences of "VerraCrypt"? Also as translating is very context dependant, I'd hope that the person submitting the translation can understand the language themselves and can oversee and verify the correctness of what the AI creates. It's not uncommon that even when I understand the language I'm translating to, I need to see where and how the string is being used in the program to actually translate it properly in the context (especially with the shorter lang strings). @sandakersmann @idrassi

@idrassi
Copy link
Member

idrassi commented Aug 22, 2024

@Jertzukka Indeed, you are making a good point. Shipping translations that are no vetted by native speakers is not good, specially for languages where the AI has little training data like for Hausa. The "VerraCrypt" issue is warning that I should have noticed and I was too quick into merging this. Thank you for your vigilance.

I will revert this commit which clearly lacks quality.

idrassi added a commit that referenced this pull request Aug 22, 2024
idrassi added a commit that referenced this pull request Aug 22, 2024
@sandakersmann
Copy link
Contributor Author

I know a guy that does translations into Hausa. I was going to ask him to look through it after it was merged.

@idrassi
Copy link
Member

idrassi commented Aug 22, 2024

Thank you for the feedback. A human review will be welcome alongside fixing the obvious issues. We can reintroduce the Hausa translation once minimal quality is ensured.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants