feat: add support for webp images #622
Open
+113
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Ready for a review! @shuding |
|
This looks cool! I can help if needed. I have a use case which I needed it for. |
|
The main problem here is that Satori only handles HTML/CSS → SVG, but the downstream solutions (vercel/og and Resvg.js) that render the SVG as an image don't support WebP inside the SVG yet. This means that even if WebP is added here, it's still not possible to render the source to rasterized images (PNG, JPEG, etc). Current blockers to get this landed: |
|
good news, resvg merged their webp support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new method to parse WEBP images and extract their dimensions. The implementation is based on the WEBP container specifications and currently supports the following WEBP specifications:
Details
The method reads and verifies the WEBP file header, then iterates through the file's chunks to extract the image dimensions. It performs necessary boundary checks to ensure the integrity of the data being read.
Specifications and References
WEBP Container Specification: Google Developers - RIFF Container
General WEBP Information: Google Developers - WEBP
Test Images: Images used for testing were sourced from Google Developers - WEBP Gallery
Fixes: #607
Fixes: #539
Fixes: #273
Fixes: #311