Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused dependency in packages/turbo-workspaces #8718

Merged
merged 7 commits into from
Nov 23, 2024
Merged

chore: remove unused dependency in packages/turbo-workspaces #8718

merged 7 commits into from
Nov 23, 2024

Conversation

torresgol10
Copy link
Contributor

I have removed some dependencies that I have not found references to within your package in packages/turbo-workspaces.

@torresgol10 torresgol10 requested a review from a team as a code owner July 10, 2024 23:22
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: turbo-workspaces labels Jul 10, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 3:37pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2024 3:37pm

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jul 11, 2024 •
edited by anthonyshew
Loading

Allow CI Workflow Run

  • approve CI run for commit: 0dc8c26

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@paulogdm paulogdm requested review from tknickman and removed request for paulogdm September 10, 2024 17:54
@tknickman
Copy link
Member

Looks good, thanks! This should auto merge once conflicts are resolved @torresgol10

@tknickman tknickman enabled auto-merge (squash) September 10, 2024 17:56
auto-merge was automatically disabled September 16, 2024 11:32

Head branch was pushed to by a user without write access

@anthonyshew
Copy link
Contributor

Uh oh, @torresgol10, we were betrayed by auto-merge on this one. Would you be able to fix the conflicts that have snuck in now that this sat for too long?

@torresgol10
Copy link
Contributor Author

@anthonyshew All conflicts resolved

@anthonyshew anthonyshew changed the title Remove unused dependency in packages/turbo-workspaces chore: remove unused dependency in packages/turbo-workspaces Nov 22, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Nov 22, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@types/rimraf@3.0.2

View full report↗︎

@anthonyshew anthonyshew merged commit 832fa25 into vercel:main Nov 23, 2024
43 checks passed
@torresgol10 torresgol10 deleted the remove-dependecy branch November 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tknickman tknickman tknickman approved these changes

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
needs: triage New issues get this label. Remove it after triage pkg: turbo-workspaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torresgol10 @ijjk @tknickman @anthonyshew