Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): with eslint flat config #9108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jnlsn
Copy link

@jnlsn jnlsn commented Sep 4, 2024

Description

I recently went through the headache of upgrading to ES Lint's flat config for a project and wanted to share what I learned here. I have cloned the basic example under with-eslint-flat-config and updated configs to be as close to the basic example while using the new flat structure. I'm happy to make this change elsewhere and/or update documentation if that is preferable. Feedback appreciated; please let me know how I can help.

Related to: #7909

Testing Instructions

  1. navigate to examples/with-eslint-flat-config
  2. pnpm i
  3. pnpm lint

@jnlsn jnlsn requested a review from a team as a code owner September 4, 2024 20:53
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Sep 4, 2024
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:53pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:53pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:53pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:53pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:53pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 8:53pm

Copy link

vercel bot commented Sep 4, 2024

@jnlsn is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@dugan-dev
Copy link

Thanks @jnlsn! I was able to mirror this PR in my repo to get everything working without issue.

@anthonyshew
Copy link
Contributor

Hey, @jnlsn! Would you want to port this work over to the basic example itself? That example needs to be migrated to v9 anyway, so it would be great to have one fewer example to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants