Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): bug in design system example #9284

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Oct 18, 2024

Description

  • add preview-storybook task to turbo.json and it's script in the root's package.json
  • improvement on clean script
  • changed the tsup config of @acme/ui package not to make source map files in order to match the content of ui/dist directory stated in README of root
  • bug fix of README file. Replaced acme-core and other names that meant to point to packages/ui with @acme/ui

Testing Instructions

Running npx create-turbo@latest -e design-system and then pnpm dev should work and start storybook in dev mode. README.md file in the root should be fine too.

@zsh77 zsh77 requested a review from a team as a code owner October 18, 2024 10:57
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 18, 2024
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 6:50pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 6:50pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 6:50pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 6:50pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 6:50pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 6:50pm

Copy link

vercel bot commented Oct 18, 2024

@zsh77 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Oct 18, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0fe2675

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@zsh77 zsh77 changed the title bug fix in design system example fix(examples): bug in design system example Oct 18, 2024
@@ -8,7 +8,8 @@
"format": "prettier --write \"**/*.{ts,tsx,md}\"",
"changeset": "changeset",
"version-packages": "changeset version",
"release": "turbo run build --filter=docs^... && changeset publish"
"release": "turbo run build --filter=docs^... && changeset publish",
"preview-storybook": "turbo preview-storybook"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's not related to this PR (as in, maybe it's already happening before this PR) but this 404's for me. does it work for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimitropoulos If you see fit, I could add this script in another merge request too. About the 404, you have to run the build script before the preview-storybook. Let me know if there was another thing going on.

…ign-system

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@zsh77
Copy link
Contributor Author

zsh77 commented Nov 5, 2024

@dimitropoulos dear Dimitri, if there's anything to improve or change I'm here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants