Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update eslint-config-turbo to support ESLint Flat Config. #9502

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

anthonyshew
Copy link
Contributor

@anthonyshew anthonyshew commented Nov 22, 2024

Description

Adds ESLint Flat Config Support to eslint-config-turbo. Users will be able to use:

import turboConfig from "eslint-config-turbo/flat"

export default [
  ...turboConfig
]

This is meant to be backwards compatible with ESLint v8, leaving the extends key in place for that purpose.

Testing Instructions

Difficult to test this, so we'll be cutting a canary shortly after to make sure.

@anthonyshew anthonyshew requested a review from a team as a code owner November 22, 2024 21:26
@turbo-orchestrator turbo-orchestrator bot added the pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo label Nov 22, 2024
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 9:33pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 9:33pm

@anthonyshew anthonyshew changed the title feat: Update eslint-config-turbo to support ESLint Flat Config. feat: Update eslint-config-turbo to support ESLint Flat Config. Nov 22, 2024
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthonyshew anthonyshew changed the title feat: Update eslint-config-turbo to support ESLint Flat Config. feat: update eslint-config-turbo to support ESLint Flat Config. Nov 22, 2024
@anthonyshew anthonyshew merged commit e92e99c into main Nov 22, 2024
39 of 43 checks passed
@anthonyshew anthonyshew deleted the shew-64c99 branch November 22, 2024 22:07
@anthonyshew anthonyshew mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants