chore(examples): remove spare dependencies from basic example #9516
+2,392
−2,283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
the
area: examples
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Skipped Deployments
|
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/eslint-config-next@15.0.3 |
chris-olszewski
requested changes
Nov 25, 2024
There was a problem hiding this comment.
If we're shipping a pnpm 9 lockfile we should bump the default package manager to match the version used to create the lockfile:
turborepo/examples/basic/package.json
Line 15 in 9db0da4
anthonyshew
changed the title
chris-olszewski
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I left some unneeded dependencies behind when I was upgrading this example in #9501. This gets rid of them.
Testing Instructions
I've verified that ESLint violations get reported as expected in my editor and when running
turbo lint. You can also clone withnpx create-turbo@canary -e https://github.com/vercel/turborepo/tree/shew-0f804/examples/basic basic-eslint-9to have a play with it.