Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/407 update vda node xxx packages #408

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Feature/407 update vda node xxx packages #408

merged 6 commits into from
Apr 29, 2024

Conversation

ITStar10
Copy link
Contributor

  • Updated the vda-node-manager and vda-node-client functions
  • Update the StorageNodeRegistry contract address and abi in the vda-common

@ITStar10
[vda-common] v3.0.2
ebd7df5 
- Update the address and abi of `StorageNodeRegistry` contract
@ITStar10
[vda-node-manager] v3.0.2
794ca6d 
- Added pagination to `getNodes...()` functions
- Added 2-step ownership transfer
- Update the test files
@ITStar10
[vda-node-client] v3.0.2
0cb6376 
- Added pagination to the `getNodesBy...()` functions
- Update the test code
@ITStar10 ITStar10 requested a review from tahpot March 22, 2024 05:52
@ITStar10 ITStar10 self-assigned this Mar 22, 2024
tahpot
tahpot requested changes Mar 24, 2024
View reviewed changes
Copy link
Member

@tahpot tahpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

packages/vda-node-manager/test/user_write.test.ts Outdated Show resolved Hide resolved
packages/vda-node-manager/test/user_read.test.ts Show resolved Hide resolved
@ITStar10
[vda-node-manager] Minor updates in test code
9357a07 
- Uncomments the `DataCentre Test` block
@ITStar10
[vda-common] v3.0.2
f4b791e 
- Updated the `StorageNodeRegistry` contract address
@ITStar10
[vda-node-manager] v3.0.2
4d1bcea 
- Added test code for pagination check (pageSize limit)
@ITStar10 ITStar10 linked an issue Mar 26, 2024 that may be closed by this pull request
[vda-node-xxx] Update for StorageNodeRegistry contract update #407
Open
tahpot
tahpot requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@tahpot tahpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the CHANGELOG.md files, please specify no date or version number. I will add these when the changes are actually published to npm, along with other changes.

@ITStar10 ITStar10 merged commit 3b70bde into develop Apr 29, 2024
@ITStar10 ITStar10 deleted the feature/407-update-vda-node-xxx-packages branch June 19, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahpot tahpot tahpot approved these changes

Assignees

@ITStar10 ITStar10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vda-node-xxx] Update for StorageNodeRegistry contract update
2 participants
@ITStar10 @tahpot