-
-
Notifications
You must be signed in to change notification settings - Fork 676
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding more
files
to the package.json
- Loading branch information
Showing
1 changed file
with
7 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@verlok what's the reason about this? The idea is that the npm package contains the least number of files needed for consumers and they are not meant for development or anything. That's why the GitHub repo exists.
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't get me wrong, but that is pretty much useless. Where did you see that?
I publish hundreds of npm packages and that thing doesn't even exist. In fact, it's pretty bad to include useless files in the npm.
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was me to suggest @verlok to add the "missing" files to the npm package... 🫥
But that is the reason:
https://github.com/npm/feedback/discussions/66#discussioncomment-114779
(Although it shouldn't be) The quality score is influenced by certain parameters such as the presence of a readme or a licence within the package you download. In some cases it makes sense (like maybe the readme) and in others (the linter file for example) absolutely not.
But this, with at the cost of a minimal load (in the end it's just a few text files) allows you to come up higher in npm searches and practically everyone that publish on npm does it
1c0d207
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted that because I agree on what @XhmikosR said, and the code quality shouldn’t be evaluated on the files you ship with npm install but on what’s in the git repository.