Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving vertx-heroku example #340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improving vertx-heroku example #340

wants to merge 1 commit into from

Conversation

Tobias-Doerner
Copy link

The current vertx-heroku example is not compiling with Java 10. sun.misc.BASE64Encoder is missing updating the heroku-maven-plugin to the current version fixes that issue. I also would like to propose to use the vertx config retriever for fetching the system properties and the config vars defined in heroku's application settings.

Updated version of the heroku-maven-plugin.

Using the vertx config retriever to retrieve the system properties and the config vars defined in heroku application settings.
@vietj
Copy link
Contributor

vietj commented Mar 13, 2019

what is using sun.misc.BASE64Encoder ?

@Tobias-Doerner
Copy link
Author

heroku-maven-plugin version 0.5.6 is using sun.misc.BASE64Encoder, look here
https://github.com/heroku/heroku-maven-plugin/blob/heroku-sdk-parent-0.5.6/heroku-deploy/src/main/java/com/heroku/sdk/deploy/Deployer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants