Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename stop word limits #4251

Merged
merged 1 commit into from
Nov 1, 2024
Merged

rename stop word limits #4251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/performance/wand_stopwords/MicroBmSearcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,27 +91,25 @@ public Result search(Query weakAndQuery, Execution execution) {
var andSet = getHitIds(andResult);

Query weakAndQuery20 = changeRoot(weakAndQuery, new WeakAndItem());
weakAndQuery20.properties().set("rankproperty.vespa.matching.weakand.stop_word_limit", "0.20");
weakAndQuery20.properties().set("rankproperty.vespa.matching.weakand.stop_word_adjust_limit", "0.20");
Result weakAndResult20 = execution.search(weakAndQuery20);
execution.fill(weakAndResult20);
var weakAndSet20 = getHitIds(weakAndResult20);

Query weakAndQuery05 = changeRoot(weakAndQuery, new WeakAndItem());
weakAndQuery05.properties().set("rankproperty.vespa.matching.weakand.stop_word_limit", "0.05");
weakAndQuery05.properties().set("rankproperty.vespa.matching.weakand.stop_word_adjust_limit", "0.05");
Result weakAndResult05 = execution.search(weakAndQuery05);
execution.fill(weakAndResult05);
var weakAndSet05 = getHitIds(weakAndResult05);

Query weakAndQueryD20 = changeRoot(weakAndQuery, new WeakAndItem());
weakAndQueryD20.properties().set("rankproperty.vespa.matching.weakand.stop_word_limit", "0.20");
weakAndQueryD20.properties().set("rankproperty.vespa.matching.weakand.stop_word_strategy", "drop");
weakAndQueryD20.properties().set("rankproperty.vespa.matching.weakand.stop_word_drop_limit", "0.20");
Result weakAndResultD20 = execution.search(weakAndQueryD20);
execution.fill(weakAndResultD20);
var weakAndSetD20 = getHitIds(weakAndResultD20);

Query weakAndQueryD05 = changeRoot(weakAndQuery, new WeakAndItem());
weakAndQueryD05.properties().set("rankproperty.vespa.matching.weakand.stop_word_limit", "0.05");
weakAndQueryD05.properties().set("rankproperty.vespa.matching.weakand.stop_word_strategy", "drop");
weakAndQueryD05.properties().set("rankproperty.vespa.matching.weakand.stop_word_drop_limit", "0.05");
Result weakAndResultD05 = execution.search(weakAndQueryD05);
execution.fill(weakAndResultD05);
var weakAndSetD05 = getHitIds(weakAndResultD05);
Expand Down
4 changes: 3 additions & 1 deletion tests/performance/wand_stopwords/wikimedia.sd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ schema wikimedia {

rank-profile default {
rank-properties {
vespa.matching.weakand.stop_word_limit: 1.0
vespa.matching.weakand.stop_word_adjust_limit: 1.0
vespa.matching.weakand.stop_word_score_limit: 1.0
vespa.matching.weakand.stop_word_drop_limit: 1.0
}
first-phase {
# expression: bm25(title) + bm25(text)
Expand Down