Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _r local vars being passed to non-ref cuda kernel pullbacks #1133

Merged
merged 15 commits into from
Nov 12, 2024
Merged

Fix _r local vars being passed to non-ref cuda kernel pullbacks #1133

merged 15 commits into from
Nov 12, 2024

Conversation

kchristin22
Copy link
Collaborator

No description provided.

@kchristin22 kchristin22 self-assigned this Nov 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (fa89545) to head (1985b86).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/Differentiator/ReverseModeVisitor.cpp 94.11% 2 Missing ⚠️
lib/Differentiator/StmtClone.cpp 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1133   +/-   ##
=======================================
  Coverage   94.47%   94.48%           
=======================================
  Files          50       50           
  Lines        8797     8848   +51     
=======================================
+ Hits         8311     8360   +49     
- Misses        486      488    +2
Files with missing lines Coverage Δ
include/clad/Differentiator/CladUtils.h 100.00% <ø> (ø)
include/clad/Differentiator/Compatibility.h 88.00% <100.00%> (+0.50%) ⬆️
include/clad/Differentiator/StmtClone.h 88.88% <ø> (ø)
lib/Differentiator/CladUtils.cpp 94.50% <100.00%> (+0.09%) ⬆️
lib/Differentiator/StmtClone.cpp 64.36% <94.11%> (+1.12%) ⬆️
lib/Differentiator/ReverseModeVisitor.cpp 95.68% <94.11%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
include/clad/Differentiator/CladUtils.h 100.00% <ø> (ø)
include/clad/Differentiator/Compatibility.h 88.00% <100.00%> (+0.50%) ⬆️
include/clad/Differentiator/StmtClone.h 88.88% <ø> (ø)
lib/Differentiator/CladUtils.cpp 94.50% <100.00%> (+0.09%) ⬆️
lib/Differentiator/StmtClone.cpp 64.36% <94.11%> (+1.12%) ⬆️
lib/Differentiator/ReverseModeVisitor.cpp 95.68% <94.11%> (-0.03%) ⬇️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Owner

Any reasonable way to test the diagnostics?

@kchristin22
Copy link
Collaborator Author

Any reasonable way to test the diagnostics?

I guess if we only omit the include paths for cuda, but these are included in the CMakeLists right?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev
vgvassilev reviewed Nov 5, 2024
View reviewed changes
lib/Differentiator/ReverseModeVisitor.cpp Outdated Show resolved Hide resolved
lib/Differentiator/ReverseModeVisitor.cpp Outdated Show resolved Hide resolved
lib/Differentiator/ReverseModeVisitor.cpp Outdated Show resolved Hide resolved
lib/Differentiator/ReverseModeVisitor.cpp Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

parth-07
parth-07 reviewed Nov 7, 2024
View reviewed changes
test/CUDA/GradientKernels.cu Show resolved Hide resolved
include/clad/Differentiator/CladUtils.h Show resolved Hide resolved
include/clad/Differentiator/Differentiator.h Show resolved Hide resolved
lib/Differentiator/ReverseModeVisitor.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

parth-07
parth-07 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@parth-07 parth-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vgvassilev vgvassilev merged commit d3292eb into vgvassilev:master Nov 12, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parth-07 parth-07 parth-07 approved these changes

@vgvassilev vgvassilev Awaiting requested review from vgvassilev

Assignees

@kchristin22 kchristin22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchristin22 @vgvassilev @parth-07