META-293 Fix multiple docs issues #81
Conversation
On class Role, change cardinality from `0..*` to `0..1` for creator, contributor, publisher and actor.
Fix language tags on description, fix `sh:datatype` and bring shacl and rdfs closer texts together.
ontologies/ebucore.rdfs.ttl
Outdated
| rdfs:label "cast members"@en ; | ||
| rdfs:label "castleden"@nl ; | ||
| rdfs:label "Membres de la distribution"@fr ; | ||
| rdfs:comment "Members of the cast."@en ; | ||
| rdfs:comment "Leden van de cast."@nl ; | ||
| rdfs:comment "Members of the cast."@fr ; |
There was a problem hiding this comment.
@lucasotodegraeve Where possible, we try to remain as closely aligned as possible with the originel ontology that is available online, so in this case the EbuCore one.
We keep the complete ontologies that the data models rely on in the folder https://github.com/viaacode/datamodels/tree/main/external_ontologies_complete and keep the actual used subset in the folder https://github.com/viaacode/datamodels/tree/main/ontologies.
In this case specifically, I would keep the labels singular and just remove the random "Range: a string or a Cast"@en (since this is indeed wrong/strange, although this happens quite a lot with online ontologies).
description/description.shacl.ttl
Outdated
| sh:or ( | ||
| [ sh:datatype xsd:string ] | ||
| [ sh:datatype ebucore:Cast ] | ||
| ); |
There was a problem hiding this comment.
@lucasotodegraeve We don't use ebucore:Cast in the data model, so I would keep this as xsd:string.
The original ontologies and our data models don't necessarily have to align this closely. We use their properties and if possible what they suggest as a range, but we choose not to when applicable :) We keep the ontology as-is because it's not ours.
|
@lucasotodegraeve Back to you (: Feel free to update the last modified dates in the headers of the relevant SHACL files (and perhaps add yourself to them as well ;) ) |
lucasotodegraeve
force-pushed
the
meta-293-fix-docs
branch
from
3188b1d
to
bebbfb8
Compare
No description provided.