Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHPY-26 Support passing includeDeleted to the records endpoint #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaameemoo
Copy link

This boolean query parameter can be used to return items when they have been logically deleted. On the off-chance that capitalization matters and to make it a little more ergonomic, we specifically handle the parameter and convert it to a string value ourselves. Additionally we allow passing other optional query parameters.

I'm not sure if the extra parameters need to be passed to the MediaHavenSingleObjectCreator.create_object) method as well (analogous to the search method)?

This boolean query parameter can be used to return items when they have
been logically deleted.  On the off-chance that capitalization matters
and to make it a little more ergonomic, we specifically handle the
parameter and convert it to a string value ourselves.  Additionally we
allow passing other optional query parameters, analogous to the way the
search method handles things.
@jaameemoo jaameemoo requested a review from spacid November 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant