Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error when polling service #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log error when polling service #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions prefect_meemoo/services/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def sync_etl_service(api_server: str, api_route: str, last_modified: str):
"""
logger = get_run_logger()
if last_modified:
logger.info(f"Start (api_server){api_route} since {last_modified}")
logger.info(f"Start {api_server}{api_route} since {last_modified}")
payload = {
"full_sync": False,
# we don't actually need a date here, full sync false is ok
Expand All @@ -55,7 +55,17 @@ def sync_etl_service(api_server: str, api_route: str, last_modified: str):
running = True
while running:
res = requests.get(f"{api_server}{api_route}")
running = res.json()["job_running"]
if not res.ok:
logger.error(f"{api_server}{api_route} poll request failed: {res.text}")
return Failed()

json_result = res.json()

if "job_running" not in json_result:
logger.error(f"{api_server}{api_route} 'job_running' parameter not found in poll response. Result JSON: {json_result}")
return Failed()

running = json_result["job_running"]
# https://github.com/PrefectHQ/prefect/issues/5635
# import subprocess
# subprocess.Popen("prefect flow-run ls >/dev/null", shell=True)
Expand Down