[RSDK-9149] Default gRPC Server to 'Wait For Handlers' #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashar-515
force-pushed
the
RSDK-9149-options
branch
from
efb95b0 to
4fe0c9d
Compare
viambot
added
safe to test
viambot
added
safe to test
bashar-515
requested review from
cheukt and
dgottlieb
and removed request for
dgottlieb and
cheukt
viambot
added
safe to test
bashar-515
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#405 Previously introduced a test failure in RDK due to a leaked Goroutine. The fix - put up in the same PR - was to always use GracefulStop() when closing the gRPC server. This is causing other tests (see the output logs here) to fail :/ As an alternative, this PR introduces the option to have a web server gracefully (or not) stop a gRPC server. This PR goes with this one, which will actually use said option in the initial tests that failed to avoid the leaked Goroutines. Once this merges, we should make a release and create a PR in RDK to run our CI tests.