igc-xc-score integration #14

mmomtchev · 2020-06-14T09:26:09Z

To be considered of alpha quality
Feel free to change colors/icons 😃
Still to be decided: what shall be and should there be any interaction between the scoring flight path and the planned flight path

vicb · 2020-06-14T15:52:18Z

frontend/src/viewer/components/path-element.ts

 const ROUTE_STROKE_COLORS = {
 [CircuitType.OPEN_DISTANCE]: '#ff6600',
 [CircuitType.OUT_AND_RETURN]: '#ff9933',
 [CircuitType.FLAT_TRIANGLE]: '#ffcc00',
 [CircuitType.FAI_TRIANGLE]: '#ffff00',
 };

+const SCORE_STROKE_COLORS = {


Do you plan to create a route instead of having a different path ?

vicb · 2020-06-14T15:53:24Z

frontend/src/viewer/components/path-element.ts

- this.faiSectors.setMap(null);
- }
+ for (let e of [this.flight, this.closingSector, this.faiSectors, this.scoring.closing, this.scoring.path])
+ if (e)


nit on style: I like to always have braces.

vicb · 2020-06-14T15:53:42Z

frontend/src/viewer/components/path-element.ts

@@ -332,13 +355,116 @@ export class PathCtrlElement extends connect(store)(LitElement) {
 }
 }

+ protected launchScoring(): void {
+ if (this.tracks && this.currentTrack !== null && this.tracks[this.currentTrack]) {
+ let fixes: BRecord[] = [];


vicb · 2020-06-14T15:54:53Z

frontend/src/viewer/components/path-element.ts

+ };
+ if (this.worker !== null)
+ this.worker.terminate();
+ this.worker = new Worker('js/xc-score-worker.js');


Do we need to create a new Worker each time ?

It is not that expensive, this is only when the user clicks the button. terminate allows the user to relaunch a new optimization even when the previous hasn't finished. Interrupting a running optimization and reusing the thread would add lots of complexity for a very marginal performance gain - currently once an optimization is launched, the thread won't yield the CPU until it is finished.

Ok, makes sense.
If the worked is not re-used then we can release it when it's done (this.worker = null).

vicb

Wahou that is super nice.
I am so delighted that this is getting integrated into FlyXC !
Thank you very much for this contribution.

2 questions/remarks:

Do you plan to update the route instead of creating a new path ?
I think it would be easier to discover the optimizer if the action was in the left panel ("Optimize") and also as discussed this should probably be started automatically when not on a mobile.

I have some style remarks (braces, trailing commas but hopefully there should be lint rules in place for that and we don't need to spend time for that).

Super boulot, merci beaucoup !

mmomtchev · 2020-06-30T20:08:22Z

https://coderwall.com/p/i817wa/one-line-function-to-detect-mobile-devices-with-javascript
Here is a practical and quite accurate solution

But then, what shall we do with the official league scoring? Both share the same output window

vicb · 2020-07-01T14:06:34Z

With regards to mobile detection anything is fine to me as long as it stays simple. Pick whichever you prefer.

But then, what shall we do with the official league scoring? Both share the same output window

The idea is that we would use the turn points from your algo and let FlyXc compute the score / distance of that particular route. Does that answer your question or do I miss something ?

vicb · 2020-07-13T13:56:16Z

Hey @mmomtchev thanks for the updates.

IIUC the scoring still does not integrate with the flyxc routes ?

Could you add more details in the PR description of what is implemented in this PR and what is left to do before we can merge ?

Thanks

vicb · 2020-09-02T01:11:33Z

frontend/src/viewer/components/path-element.ts

+ longitude: this.tracks[this.currentTrack].fixes.lon[i],
+ pressureAltitude: this.tracks[this.currentTrack].fixes.alt[i],
+ gpsAltitude: this.tracks[this.currentTrack].fixes.alt[i],
+ valid: true,


Do we need to specify all the records that have a constant value ? (valid -> enl)

vicb · 2020-09-02T01:13:22Z

frontend/src/workers/xc-score-worker.ts

+import { IGCFile } from 'igc-parser';
+
+/* The joy of JS multithreading */
+function filterFunc(o: any): object {


Could we drop that an be explicit in what we pass instead of using filterFunc(something) ?

vicb · 2020-09-02T01:17:04Z

frontend/src/viewer/components/path-element.ts

+ this.worker.terminate();
+ this.worker = new Worker('js/xc-score-worker.js');
+ this.worker.onmessage = this.updateScore.bind(this);
+ this.worker.postMessage({ msg: 'xc-score-start', flight: JSON.stringify(fixes), league: this.league });


It might be nice to use a protobuf (ArrayBuffer) instead of JSON.
It is faster to encode/decode and less memory intensive (does not encoded the field names).
The only thing is that we would need the [en/de]coding logic on the worker side which is ~3kB - probably not a big deal once the worker is cached.

(Note: this is a nice to have, not required for the optimization to be merged).

vicb · 2024-06-03T11:35:52Z

@flyingtof has been looking at that in #203

mmomtchev added 7 commits June 11, 2020 21:20

WIP: initial integration of igc-xc-score, only scoring, no map details

afebf44

upgrade igc-xc-score to 1.4.0

b5f22ae

add XContest rule names

9eddbe8

chrome debugging in vscode

fac015e

igc-xc-score integration

7cbbf3a

Merge branch 'master' of github.com:vicb/flyxc

c5b29b6

remove scoring path on component close

994b78d

vicb self-requested a review June 14, 2020 15:42

vicb reviewed Jun 14, 2020

View reviewed changes

vicb marked this pull request as draft June 14, 2020 16:17

mmomtchev added 2 commits June 15, 2020 19:25

respect code style

7b2d64e

respect code style

2d205cf

mmomtchev added 3 commits July 12, 2020 16:49

add mobile detection (disabled)

4f50156

merge upstream

fdeeec7

update igc-xc-score to 1.5.0

08456b5

mmomtchev marked this pull request as ready for review July 12, 2020 15:31

vicb force-pushed the master branch from 0ae9bbf to 5f6f4b4 Compare July 15, 2020 19:51

vicb force-pushed the master branch from 01ba523 to 0d00306 Compare July 29, 2020 00:17

vicb reviewed Sep 2, 2020

View reviewed changes

vicb force-pushed the master branch 2 times, most recently from 58fa3ad to 8d8a948 Compare November 10, 2020 04:25

vicb force-pushed the master branch 2 times, most recently from 7813cd2 to aab1cd4 Compare January 24, 2022 20:23

vicb force-pushed the master branch 2 times, most recently from 09b57a5 to ee288b2 Compare October 25, 2022 22:12

vicb force-pushed the master branch from f2e71bc to 1053666 Compare December 8, 2022 22:28

vicb force-pushed the master branch from b7ef2ae to 3d2f56f Compare March 5, 2024 14:47

vicb closed this Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

igc-xc-score integration #14

igc-xc-score integration #14

mmomtchev commented Jun 14, 2020

vicb Jun 14, 2020

vicb Jun 14, 2020

vicb Jun 14, 2020

vicb Jun 14, 2020

mmomtchev Jun 15, 2020

vicb Jun 15, 2020

vicb left a comment

mmomtchev commented Jun 30, 2020

vicb commented Jul 1, 2020

vicb commented Jul 13, 2020

vicb Sep 2, 2020 •

edited

Loading

vicb Sep 2, 2020

vicb Sep 2, 2020 •

edited

Loading

vicb commented Jun 3, 2024

igc-xc-score integration #14

igc-xc-score integration #14

Conversation

mmomtchev commented Jun 14, 2020

vicb Jun 14, 2020

Choose a reason for hiding this comment

vicb Jun 14, 2020

Choose a reason for hiding this comment

vicb Jun 14, 2020

Choose a reason for hiding this comment

vicb Jun 14, 2020

Choose a reason for hiding this comment

mmomtchev Jun 15, 2020

Choose a reason for hiding this comment

vicb Jun 15, 2020

Choose a reason for hiding this comment

vicb left a comment

Choose a reason for hiding this comment

mmomtchev commented Jun 30, 2020

vicb commented Jul 1, 2020

vicb commented Jul 13, 2020

vicb Sep 2, 2020 • edited Loading

Choose a reason for hiding this comment

vicb Sep 2, 2020

Choose a reason for hiding this comment

vicb Sep 2, 2020 • edited Loading

Choose a reason for hiding this comment

vicb commented Jun 3, 2024

vicb Sep 2, 2020 •

edited

Loading

vicb Sep 2, 2020 •

edited

Loading