Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(api): add GraphQL support to enhance data querying flexibility #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

annaelmoussa
Copy link

Add GraphQL Support to Octagon API

Description

This PR introduces GraphQL support to our Octagon API, enhancing the flexibility and efficiency of data querying for our users.

Changes

  • Implemented GraphQL schema for existing data models
  • Added GraphQL resolvers for fighters, rankings, and divisions
  • Integrated GraphQL server with existing Hono setup
  • Updated API documentation to include GraphQL usage and examples
  • Added GraphQL endpoint (/graphql) alongside existing REST endpoints

Testing

  • Manually tested GraphQL queries for all main data types
  • Verified that existing REST endpoints continue to function as expected
  • Tested GraphQL playground for interactive query exploration

Documentation

  • Updated README.md with GraphQL information
  • Added detailed GraphQL documentation in api-documentation.mdx

Dependencies

  • Added @graphql-tools/schema for schema creation
  • Added @hono/graphql-server for GraphQL server integration with Hono

Notes for Reviewers

  • Please check the GraphQL schema design for any potential improvements
  • Verify that the integration doesn't impact the performance of existing endpoints
  • Suggestions for additional example queries in the documentation are welcome

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octagon-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 9:29am

@victor-lillo
Copy link
Owner

Hello @annaelmoussa! First of all, thanks for contributing to the repo!

I will be away on vacation for a few days. I will check this PR when I'm back and as soon as possible.

@annaelmoussa
Copy link
Author

Hi @victor-lillo,

Thank you for your response and for taking the time to reply.

Enjoy your vacation! When you're back, please check the GraphQL schema design for any potential improvements. Also, make sure the integration doesn't impact the performance of existing endpoints. If you have any suggestions for additional example queries to include in the documentation, they are more than welcome.

Have a great holiday and see you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants