fix(i18n): ignore i18n modifiers #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! Sorry the code is a mess, i have a plan to refactor everything for 4.0 but lack motivation 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue #149, where router dependent functions such as
localePathornuxtLinkLocalewould break if i18n was on with the strategyprefix_and_default, the bug might occur with other strategies, this has not been tested for the moment.An option has been added
ignoreI18nModifiersset by default to false to assure backwards compatibility, setting the option to true will prevent the generator from changing the routes names.I haven't found any functionality that has been broken from this change yet