Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#69] Add disableEditButton option to module config #70

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

maxfenton
Copy link
Contributor

@maxfenton maxfenton commented Oct 26, 2023


Add a disableEditButton configuration option and check that when deciding whether or not to output an Edit Entry button on the front-end.

This allows us to set a value in config/viget.php to bypass the built-in logic.

@maxfenton maxfenton self-assigned this Oct 26, 2023
@maxfenton maxfenton requested a review from joshuapease October 26, 2023 17:31
Copy link
Contributor

@joshuapease joshuapease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxfenton
Copy link
Contributor Author

maxfenton commented Oct 26, 2023

This is working as expected on https://staging.loveyourmindtoday.org/life-challenges/workplace-issues-unemployment — when I change the .env to set DEV_MODE to false, the red button disappears.

(And setting DEV_MODE to true prevents Blitz caching so flipping that back and forth does not cause stuck caches with the button)

@joshuapease joshuapease merged commit 3cc6a97 into v5 Oct 26, 2023
@maxfenton maxfenton deleted the mf/69-no-cache branch October 26, 2023 19:02
@maxfenton maxfenton restored the mf/69-no-cache branch October 26, 2023 19:03
@maxfenton maxfenton deleted the mf/69-no-cache branch October 26, 2023 19:03
@ten1seven
Copy link

@maxfenton can you please add info about this to the docs?

maxfenton added a commit that referenced this pull request Nov 1, 2023
maxfenton added a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants