[#75] Remove phone home code #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapease
commented
Apr 15, 2024
| @@ -21,7 +21,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^8.0.2", | |||
| "craftcms/cms": "^4.0.0-alpha", | |||
| "craftcms/cms": "^4.3.5", | |||
There was a problem hiding this comment.
PHPStan called out that the onInit method we're using in Module.php is only available in >=4.3.5
Gotta love static analysis
JJimmyFlynn
approved these changes
Apr 15, 2024
maxfenton
approved these changes
Apr 16, 2024
maxdmyers
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
phone-homeplugin #75We're moving out site inventory (phone home) to Notion and a standalone plugin.
I also added PHPStan to help catch any missing references to the Phone Home plugin. Figure it'll be nice to have on the project.