Fix URL filename extraction in mods_downloader.sh #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Gets the filename from the server headers (content-disposition: filename) * Fallback to extracting using basename by removing the query parameter(s)
|
Hi thanks for the fix @msansen, really nice addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cases when the url could contain query parameters (eg gitlab links with path)
The fix gets the filename from the server headers
content-disposition: attachment; filename="real_filename.zip"and fallback to extracting usingbasenameby removing the query parameter(s):$(basename "${url%%\?*}")