-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Markdown formatting in docs #65
Use Markdown formatting in docs #65
Conversation
@vincentarelbundock
which generates a warning |
yeah, IIRC, these were never intended to be exported. So it's a breaking change but only because of a docs issue. I'm happy with any solution you want to implmeent |
I removed them since it's the fastest to do and they have "internal function" in the title anyway |
Do you have any idea why this fails? library(WDI)
cache = WDIcache()
old <- WDIsearch('gdp.*capita.*constant')
new <- WDIsearch("gdp.*capita.*constant", cache = cache)
waldo::compare(old, new)
#> `attr(old, 'row.names')`: 717 11431 11433 11435 11436
#> `attr(new, 'row.names')`: 692 12372 12374 12376 12377
#>
#> old vs new
#> name
#> old[1, ] GDP per capita, PPP (constant 2011 international $)
#> old[2, ] GDP per capita (constant 2015 US$)
#> old[3, ] GDP per capita (constant LCU)
#> - old[4, ] GDP per capita, PPP (constant 2017 international $)
#> + new[4, ] GDP per capita, PPP (constant 2021 international $)
#> old[5, ] GDP per capita, PPP (constant 1987 international $)
#>
#> old$name vs new$name
#> "GDP per capita, PPP (constant 2011 international $) "
#> "GDP per capita (constant 2015 US$)"
#> "GDP per capita (constant LCU)"
#> - "GDP per capita, PPP (constant 2017 international $)"
#> + "GDP per capita, PPP (constant 2021 international $)"
#> "GDP per capita, PPP (constant 1987 international $)" My guess is that we should update |
Yep, I think that's the problem. I pushed a new search cache and added a note to the readme to indicate how to do it. |
Thanks! |
I just realized that markdown syntax is used in (part of) the docs but wasn't properly rendered (see for instance the
*
not rendered as bullet points in?languages_supported
). This PR fixes that and oneroxygen2
warning about the deprecated usage of@docType package
.Edit: used this occasion to also update the CI workflow