Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldk: upgrade to the last ldk master version #118

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

vincenzopalazzo
Copy link
Owner

In the process of making lampo compatible with ldk 117 version, there was the following breaking change that this commit addresses.

@vincenzopalazzo
Copy link
Owner Author

Missing the bdk upgrade

@vincenzopalazzo

This comment was marked as off-topic.

@vincenzopalazzo vincenzopalazzo deleted the macros/update-ldk branch October 2, 2023 20:04
@vincenzopalazzo vincenzopalazzo restored the macros/update-ldk branch October 3, 2023 15:08
@vincenzopalazzo vincenzopalazzo deleted the macros/update-ldk branch October 3, 2023 20:13
@vincenzopalazzo vincenzopalazzo restored the macros/update-ldk branch October 10, 2023 07:21
@vincenzopalazzo vincenzopalazzo deleted the macros/update-ldk branch October 10, 2023 21:13
@Harshit933 Harshit933 restored the macros/update-ldk branch October 13, 2023 14:47
@Harshit933 Harshit933 reopened this Oct 13, 2023
@Harshit933
Copy link
Collaborator

Tested it on my machine and it works good!

@vincenzopalazzo
Copy link
Owner Author

I found also why this PR was closed so many times :) Now it should be ok

@vincenzopalazzo vincenzopalazzo force-pushed the macros/update-ldk branch 2 times, most recently from 4eeb6e6 to d52b3d0 Compare October 27, 2023 16:45
@vincenzopalazzo
Copy link
Owner Author

Ok Rebased on master and fixed the bdk support

In the process of making lampo compatible with ldk 117
version, there was the following breaking change that
this commit addresses.

- Add read_channel_monitors utility in
lightningdevkit/rust-lightning@4305ee4
- Add FilesystemStore and remote the Add FilesystemPersister
lightningdevkit/rust-lightning@f22d1b6
- Expose AChannelManager trait and use it in lightning-invoice in Expose AChannelManager trait and use it in lightning-invoice

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo merged commit 04bce12 into main Oct 27, 2023
3 of 4 checks passed
@vincenzopalazzo vincenzopalazzo deleted the macros/update-ldk branch October 27, 2023 18:32
@vincenzopalazzo vincenzopalazzo restored the macros/update-ldk branch December 5, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants