Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize SimpleMessagesProvider into JSON #19

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Serialize SimpleMessagesProvider into JSON #19

merged 3 commits into from
Oct 16, 2023

Conversation

TiBianMod
Copy link
Contributor

This PR adds support for JSON serialization of SimpleMessagesProvider class

Before

CleanShot 2023-09-27 at 08 51 13

After

CleanShot 2023-09-27 at 08 52 17

@TiBianMod
Copy link
Contributor Author

cc, @thetutlage @RomainLanz

@thetutlage
Copy link
Contributor

Hey, can you please pin the @swc/core version. The latest version has breaking changes and making the tests fail.

npm i -D @swc/core@1.3.82 --save-exact

@TiBianMod
Copy link
Contributor Author

I think we are ready 😄

@thetutlage thetutlage merged commit 72d098d into vinejs:develop Oct 16, 2023
6 checks passed
@thetutlage
Copy link
Contributor

Cool. Looks great

@TiBianMod TiBianMod deleted the json-serialization branch October 16, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetutlage thetutlage thetutlage left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiBianMod @thetutlage