Export base schema classes #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey! could you provide a minimal reproduction repo please? Thanks |
|
oops didn't see it was a pull request. so yeah, it could be great if you could create an issue before please |
Sure, when you try to build the project it will fail since it cannot include the types: https://github.com/adrianNEMO/vine-package-example |
|
Merged in #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
When a vine validator is exported by another package (e.g. a common package in a monorepo), which is built by tsc it cannot be compiled since tsc cant reference the schema base classes. By exporting the classes and including the path in the
package.jsonexports this gets fixed.📝 Checklist