feat: 🎸 make item and itemContent props customizable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the broken type inference caused by using forwardRef. See: https://react-typescript-cheatsheet.netlify.app/docs/basic/getting-started/forward_and_create_ref/#generic-forwardrefs
Add getItemProps and getItemContentProps to allow customizing the props of the wrapper item and the item content ✅ Closes: vingeraycn#21
vingeraycn
approved these changes
Nov 1, 2023
Merged
vingeraycn
added a commit
that referenced
this pull request
Nov 27, 2023
* feat: 🎸 make item and itemContent props customizable (#25) * fix: 🐛 fix type inference for props Fix the broken type inference caused by using forwardRef. See: https://react-typescript-cheatsheet.netlify.app/docs/basic/getting-started/forward_and_create_ref/#generic-forwardrefs * feat: 🎸 make item and itemContent props customizable Add getItemProps and getItemContentProps to allow customizing the props of the wrapper item and the item content ✅ Closes: #21 * refactor: clean code --------- Co-authored-by: blaiseludvig <blaiseludvig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getItemProps and getItemContentProps to allow customizing the props
of the wrapper item and the item content
Also, this fixes the broken type inference caused by using forwardRef. See:
https://react-typescript-cheatsheet.netlify.app/docs/basic/getting-started/forward_and_create_ref/#generic-forwardrefs
No breaking changes are made, everything can be applied as a patch to the current version.
Should be ready for review!