[CLOYSTER-104] Preliminary support to dbus, plus a daemon management class #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbus-cpp will be our dbus communication library, this commit adds it
Here, we encapsulate the sdbus communication classes, instead of using them directly, so we can mock them later We do not encapsulate the data types though, because it is not worth it: they are simple enough to be instantiated, and the library depends on they being the exact type, not subclasses or anything other
This daemon handler class will manage the daemons we configure (start, stop, reload etc) using dbus (or any other message bus, such as the test one, to allow easy mocking) We also add a test message bus to test this daemon handler
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when we needed to manage a daemon, we called systemd using the command line.
This is not good for a series of reasons: complex error handling, depending on the necessary process quota, feeling of sloppiness...
This PR start adding a DBus management class, plus a
DaemonHandlerclass, to do all the required tasks.This also fixes some memory leaks I found
(Note that most operations do not exist, and will be added as required, when we start implementing the
DaemonHandler. This PR only add sufficient support for us to "start get going", and to acquire opinions)