Merge pull request #8 from vinted/fix/retry_on_error_config

Configure if should retry metrics retrieval on error.
vinted · Oct 9, 2024 · 4e1596a · 4e1596a
2 parents 9e158f1 + 0c606ee
commit 4e1596a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/config_example.json b/config_example.json
@@ -2,6 +2,7 @@
   "graphqlURL": "http://localhost:8090/graphql/",
   "graphqlAPIToken": "Token SECRET",
   "cacheExpire": 0,
+  "retryOnError": false,
   "metricsPrefix": "graphql_exporter_",
   "queries":[
     {

diff --git a/internal/config/config.go b/internal/config/config.go
@@ -11,6 +11,7 @@ type Cfg struct {
 	GraphqlURL      string
 	GraphqlAPIToken string
 	CacheExpire     int64
+	RetryOnError    bool
 	MetricsPrefix   string
 	Queries         []Query
 }

diff --git a/internal/prometheus/prometheus.go b/internal/prometheus/prometheus.go
@@ -161,14 +161,18 @@ func (collector *GraphqlCollector) updateMetrics() error {
 		ctx, cancel := context.WithTimeout(context.Background(), time.Second*30)
 		defer cancel()
 		metrics, err := collector.getMetrics(ctx)
+		collector.accessMu.Lock()
+		defer collector.accessMu.Unlock()
 		if err != nil {
 			slog.Error(fmt.Sprintf("error collecting metrics: %s", err))
+			if !config.Config.RetryOnError {
+				collector.cachedAt = time.Now().Unix()
+			}
 			return err
+		} else {
+			collector.cachedMetrics = metrics
+			collector.cachedAt = time.Now().Unix()
 		}
-		collector.accessMu.Lock()
-		collector.cachedMetrics = metrics
-		collector.cachedAt = time.Now().Unix()
-		collector.accessMu.Unlock()
 	}
 	return nil
 }