fix ndjson parsing in Python client #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpxis using the stdlibsplitlinesmethod foraiter_lines, but the NDJSON spec states that only\n(0x0A) should be treated as a line separator when parsing NDJSON.This meant that if the server response contains other characters considered to be line separators by the Python stdlib, it would fail to correctly parse the (ND)JSON. So we fix this by copying the
LineDecoderand modifying it to keep the line "ends" and then stitch the lines back together with the ends if the end is not\n.