feat(protocol): add serverless protocol library #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
mmoreiradj
force-pushed
the
feat/serverless-protocol
branch
from
3f5db89 to
9e435c4
Compare
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
mmoreiradj
force-pushed
the
feat/serverless-protocol
branch
from
78da532 to
e597272
Compare
|
Added libudev-dev in github actions step |
…pe to checksum (#2) * feat: make checksum from payload as bytes instead of relying on serde_json::to_string * feat: rework checksum to add message_type feat: rework checksum to use sha256 Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
mmoreiradj
force-pushed
the
feat/serverless-protocol
branch
from
39034a8 to
0464cae
Compare
|
The checksum is now calculated using the content of the payload and the message type, without relying on |
remi-espie
approved these changes
Apr 17, 2024
src/serverless_protocol/README.md
Outdated
| 2. Run the example: | ||
|
|
||
| ```bash | ||
| cargo run --example cargo run --example serverless_protocol_example -- --serial-path-a=<path_to_first_pty> --serial-path-b=<path_to_second_pty> |
There was a problem hiding this comment.
Remove typo
Suggested change
| cargo run --example cargo run --example serverless_protocol_example -- --serial-path-a=<path_to_first_pty> --serial-path-b=<path_to_second_pty> | |
| cargo run --example serverless_protocol_example -- --serial-path-a=<path_to_first_pty> --serial-path-b=<path_to_second_pty> |
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
mmoreiradj
force-pushed
the
feat/serverless-protocol
branch
from
c07b01a to
2591a22
Compare
|
@charley04310 @thomas-mauran does this match your needs ? |
|
closed in favor of this, we dont need this protocol, we can just use the network now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a lib to communicate over a serial port.
Added README on how to test it.
I think one point of improvement is to not calculate the checksum from the payload converted to json as we don't know wether serde or another json converter parser will convert it the same way.