Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fs-gen): stable version with agent insertion #30

Merged
merged 25 commits into from
Apr 26, 2024
Merged

feat(fs-gen): stable version with agent insertion #30

merged 25 commits into from
Apr 26, 2024

Conversation

BioTheWolff
Copy link
Contributor

This PR adds several functionalities:

  • --arch argument to specify which architecture we want to download, if the manifest contains several
  • --initfile argument, which takes a path in the host to copy the initfile from. If not given, the default initfile contained within the crate will be applied
  • the agent is now placed under /agent in the rootFS, and executed by the default initfile
  • logging has been implemented using tracing and tracing_subscriber
  • crate now has better handling using anyhow for error reporting, and thiserror for error generation

@Mathias-Boulay @BioTheWolff
fix(image-builder): use the proper tmp path
bcf927f 
Signed-off-by: Mathias-Boulay <mathiasboulay@free.fr>
@Mathias-Boulay @BioTheWolff
refactor: use a subfolder by default
0b580e5 
Signed-off-by: Mathias-Boulay <mathiasboulay@free.fr>
@BioTheWolff BioTheWolff self-assigned this Apr 26, 2024
Mathias-Boulay and others added 22 commits April 26, 2024 12:55
@Mathias-Boulay @BioTheWolff
feat(arg-parsing): make the tag optional (#4)
320bdfb 
Signed-off-by: Mathias Boulay <mathiasboulay@free.fr>
@BioTheWolff
refactor: change default temp directory
e2c3e26 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: insert initfile from command-line argument
526db41 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: load initfile using include_str
eb4e670 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: insert agent when building initramfs
0b08f32 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
chore: add tracing crate
d962d89 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: implement tracing for crate
88412a1 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
lint: remove unused import
9d943d3 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: implement better error handling for initramfs generation
5a1dc24 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: add error handling for image loading
60c5b04 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: log errors for each soft unwrap
b0e4143 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: simplify error handling in main function
1c1ac09 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: rework architecture for downloading and unpacking
e6bf37e 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: improve horizontality of code in loader submodules
f5eaa4d 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
lint: correct for clippy
bb5a6f6 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: implement architecture choice when building initramfs
2dd018d 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: get subdirs in run function
971d355 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: add warning when no architecture in manifest
ccaaf20 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: add new initfile version
2b38a1a 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
chore: remove empty test file
88f5996 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
refactor: suppress info level for fuse backend crate
69093ed 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
feat: add info logging for layers merging
a362377 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
@BioTheWolff
chore: cargo fmt
360ce44 
Signed-off-by: BioTheWolff <47079795+BioTheWolff@users.noreply.github.com>
Mathias-Boulay
Mathias-Boulay reviewed Apr 26, 2024
View reviewed changes
src/fs-gen/src/main.rs
)
.init();

// tracing_subscriber::fmt()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be removed

@BioTheWolff BioTheWolff merged commit 5b3ffbb into virt-do:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathias-Boulay Mathias-Boulay Mathias-Boulay left review comments

@sea-gull-diana sea-gull-diana sea-gull-diana approved these changes

Assignees

@BioTheWolff BioTheWolff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BioTheWolff @Mathias-Boulay @sea-gull-diana