-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: get internet access #39
Merged
sylvain-pierrot
merged 7 commits into
virt-do:main
from
sylvain-pierrot:feat/get-internet-access
May 2, 2024
Merged
feat: get internet access #39
sylvain-pierrot
merged 7 commits into
virt-do:main
from
sylvain-pierrot:feat/get-internet-access
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuruyia
reviewed
May 2, 2024
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
sylvain-pierrot
force-pushed
the
feat/get-internet-access
branch
from
May 2, 2024 20:01
1ba3135
to
1cbd327
Compare
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Kuruyia
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bridge interface and the iptables rules will stay after the VMM is closed, otherwise LGTM!
remi-espie
pushed a commit
to remi-espie/cloudlet
that referenced
this pull request
May 3, 2024
* feat: create bridge interface Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * feat: create bridge only if not exist Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * fix: cargo clippy Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * feat: send code though gRPC to the agent (virt-do#37) * feat(agent/proto): add agent configuration in execute request Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> * feat: send code through cli and api to vm Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> --------- Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> * Feat: add initramfs implementation for vmm (virt-do#34) * feat(vmm): implemented automatic generation of rootfs with initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat: image generation based off language Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): implemented automatic generation of rootfs with initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): fix logging & language order Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): one image per language Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): implemented initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix: rust export for cargo agent and increase MMIO_GAP_END Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> * chore: lint Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> * fix: add back tracing Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> --------- Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr> * feat: internet works Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * fix: cargo clippy Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> --------- Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Co-authored-by: Thomas Mauran <78204354+thomas-mauran@users.noreply.github.com> Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Co-authored-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>
MurielParaire
added a commit
to MurielParaire/cloudlet
that referenced
this pull request
May 3, 2024
* feat: create bridge interface Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * feat: create bridge only if not exist Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * fix: cargo clippy Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * feat: send code though gRPC to the agent (virt-do#37) * feat(agent/proto): add agent configuration in execute request Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> * feat: send code through cli and api to vm Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> --------- Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> * Feat: add initramfs implementation for vmm (virt-do#34) * feat(vmm): implemented automatic generation of rootfs with initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat: image generation based off language Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): implemented automatic generation of rootfs with initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): fix logging & language order Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): one image per language Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): implemented initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix: rust export for cargo agent and increase MMIO_GAP_END Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> * chore: lint Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> * fix: add back tracing Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> --------- Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr> * feat: internet works Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * fix: cargo clippy Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> --------- Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Co-authored-by: Thomas Mauran <78204354+thomas-mauran@users.noreply.github.com> Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Co-authored-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr> Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
MurielParaire
added a commit
to MurielParaire/cloudlet
that referenced
this pull request
May 3, 2024
* feat: create bridge interface Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * feat: create bridge only if not exist Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * fix: cargo clippy Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * feat: send code though gRPC to the agent (virt-do#37) * feat(agent/proto): add agent configuration in execute request Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> * feat: send code through cli and api to vm Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> --------- Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> * Feat: add initramfs implementation for vmm (virt-do#34) * feat(vmm): implemented automatic generation of rootfs with initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat: image generation based off language Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): implemented automatic generation of rootfs with initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): fix logging & language order Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): one image per language Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * feat(vmm): implemented initramfs Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix(vmm): code cleanup Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> * fix: rust export for cargo agent and increase MMIO_GAP_END Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> * chore: lint Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> * fix: add back tracing Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> --------- Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr> * feat: internet works Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> * fix: cargo clippy Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> --------- Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr> Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr> Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Co-authored-by: Thomas Mauran <78204354+thomas-mauran@users.noreply.github.com> Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com> Co-authored-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com> Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr> Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Cloudlet to access internet
Description:
The purpose of this Pull Request is to allow Cloudlet to access internet.
Changes Introduced (checklist):