Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get internet access #39

Merged

Conversation

sylvain-pierrot
Copy link
Contributor

@sylvain-pierrot sylvain-pierrot commented May 2, 2024

Allow Cloudlet to access internet

Description:

The purpose of this Pull Request is to allow Cloudlet to access internet.

Changes Introduced (checklist):

  • Create bridge on host
  • Set address to bridge rather than tap
  • Set bridge as master for tap
  • Ip Masquerade

@sylvain-pierrot sylvain-pierrot requested a review from Kuruyia May 2, 2024 08:40
@sylvain-pierrot sylvain-pierrot self-assigned this May 2, 2024
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
@sylvain-pierrot sylvain-pierrot force-pushed the feat/get-internet-access branch from 1ba3135 to 1cbd327 Compare May 2, 2024 20:01
@sylvain-pierrot sylvain-pierrot requested a review from Kuruyia May 2, 2024 20:06
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Copy link
Contributor

@Kuruyia Kuruyia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bridge interface and the iptables rules will stay after the VMM is closed, otherwise LGTM!

@sylvain-pierrot sylvain-pierrot merged commit a722df8 into virt-do:main May 2, 2024
2 checks passed
@sylvain-pierrot sylvain-pierrot deleted the feat/get-internet-access branch May 2, 2024 20:41
remi-espie pushed a commit to remi-espie/cloudlet that referenced this pull request May 3, 2024
* feat: create bridge interface

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* feat: create bridge only if not exist

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* fix: cargo clippy

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* feat: send code though gRPC to the agent (virt-do#37)

* feat(agent/proto): add agent configuration in execute request

Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>

* feat: send code through cli and api to vm

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

---------

Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>

* Feat: add initramfs implementation for vmm (virt-do#34)

* feat(vmm): implemented automatic generation of rootfs with initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat: image generation based off language

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): implemented automatic generation of rootfs with initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): fix logging & language order

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): one image per language

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): implemented initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix: rust export for cargo agent and increase MMIO_GAP_END

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* chore: lint

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* fix: add back tracing

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

---------

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* feat: internet works

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* fix: cargo clippy

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

---------

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Co-authored-by: Thomas Mauran <78204354+thomas-mauran@users.noreply.github.com>
Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Co-authored-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>
MurielParaire added a commit to MurielParaire/cloudlet that referenced this pull request May 3, 2024
* feat: create bridge interface

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* feat: create bridge only if not exist

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* fix: cargo clippy

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* feat: send code though gRPC to the agent (virt-do#37)

* feat(agent/proto): add agent configuration in execute request

Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>

* feat: send code through cli and api to vm

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

---------

Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>

* Feat: add initramfs implementation for vmm (virt-do#34)

* feat(vmm): implemented automatic generation of rootfs with initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat: image generation based off language

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): implemented automatic generation of rootfs with initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): fix logging & language order

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): one image per language

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): implemented initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix: rust export for cargo agent and increase MMIO_GAP_END

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* chore: lint

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* fix: add back tracing

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

---------

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* feat: internet works

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* fix: cargo clippy

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

---------

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Co-authored-by: Thomas Mauran <78204354+thomas-mauran@users.noreply.github.com>
Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Co-authored-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
MurielParaire added a commit to MurielParaire/cloudlet that referenced this pull request May 3, 2024
* feat: create bridge interface

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* feat: create bridge only if not exist

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* fix: cargo clippy

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* feat: send code though gRPC to the agent (virt-do#37)

* feat(agent/proto): add agent configuration in execute request

Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>

* feat: send code through cli and api to vm

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

---------

Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>

* Feat: add initramfs implementation for vmm (virt-do#34)

* feat(vmm): implemented automatic generation of rootfs with initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat: image generation based off language

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): implemented automatic generation of rootfs with initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): fix logging & language order

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): one image per language

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* feat(vmm): implemented initramfs

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix(vmm): code cleanup

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>

* fix: rust export for cargo agent and increase MMIO_GAP_END

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* chore: lint

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* fix: add back tracing

Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>

---------

Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>

* feat: internet works

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

* fix: cargo clippy

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>

---------

Signed-off-by: sylvain-pierrot <sylvain.pierrot@etu.umontpellier.fr>
Signed-off-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Signed-off-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Co-authored-by: Thomas Mauran <78204354+thomas-mauran@users.noreply.github.com>
Co-authored-by: Martin Moreira de Jesus <martin.moreira-de-jesus@protonmail.com>
Co-authored-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Co-authored-by: Mauran <thomas.mauran@etu.umontpellier.fr>
Signed-off-by: Muriel Paraire <72733662+MurielParaire@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants