Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description Snippet created #1202

Conversation

kain-ap
Copy link
Contributor

@kain-ap kain-ap commented Aug 14, 2024

IDescription as general snippet has been created for the note for all the structural Elements of Concepts.

@kain-ap kain-ap linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link
Member

@franzTobiasDLR franzTobiasDLR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! Didn't know that we actually have this property in our DVLM model...

@franzTobiasDLR
Copy link
Member

For others... Here is a screenshot of the new snippet:
grafik

Copy link
Member

@PhilMFischer PhilMFischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding refactoring and one regarding inconsistent indentation of the code. please fix.

Copy link
Contributor

@dellerDLR dellerDLR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version has a conflicting .mailmap, but despite that looks good :)

@PhilMFischer PhilMFischer dismissed dellerDLR’s stale review October 22, 2024 11:38

Requests should be adressed and code looks fine to be taken into development

@kain-ap kain-ap merged commit f1802e5 into development Oct 22, 2024
12 checks passed
@kain-ap kain-ap deleted the feature/1168-add-a-description-string-field-to-elements-of-the-ps-concept branch October 22, 2024 11:38
@kain-ap
Copy link
Contributor Author

kain-ap commented Oct 22, 2024

Closes #1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a description string field to elements of the PS concept
4 participants