-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description Snippet created #1202
Description Snippet created #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool! Didn't know that we actually have this property in our DVLM model...
...ngine.ui/src/de/dlr/sc/virsat/uiengine/ui/editor/snippets/general/UiSnippetIDescription.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment regarding refactoring and one regarding inconsistent indentation of the code. please fix.
...ngine.ui/src/de/dlr/sc/virsat/uiengine/ui/editor/snippets/general/UiSnippetIDescription.java
Outdated
Show resolved
Hide resolved
...ngine.ui/src/de/dlr/sc/virsat/uiengine/ui/editor/snippets/general/UiSnippetIDescription.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current version has a conflicting .mailmap, but despite that looks good :)
feature/1168-add-a-description-string-field-to-elements-of-the-ps-concept
Requests should be adressed and code looks fine to be taken into development
Closes #1168 |
IDescription as general snippet has been created for the note for all the structural Elements of Concepts.