Modified version for cmake 3.16 #6
Conversation
|
this version can compile with cmake 3.16 |
| @@ -25,6 +25,7 @@ endif() | |||
| include(CTest) | |||
|
|
|||
| add_subdirectory(src) | |||
| add_subdirectory(test) | |||
There was a problem hiding this comment.
I already include the test directory (see below) but only if the project is at the top level. We could just remove that check instead.
test/vrEmu6502.h
Outdated
There was a problem hiding this comment.
Was this file added by mistake?
There was a problem hiding this comment.
99.9999% for mistake. To be honest I don't know the CMake utility, I messed around and likely I forgot to remove it. I did this change because upgrading cmake on Raspberry PI ==> you need to upgrade the whole universe.
vrEmu6502 is really the best 6502 family Emulator, I'm working to use it inside a PICO PI as an accelerator card.
There was a problem hiding this comment.
How should we proceed?
There was a problem hiding this comment.
Either you fix this pull request (remove the accidental addition of test/vrEmu6502.h and remove the add_subdirectory(test) line) or, I'll make separate changes to reduce the CMake version.
If you fix the pull request, I'll approve it. Otherwise, later this week, I'll make the changes.
There was a problem hiding this comment.
Sorry for the late answer, I'll fix the pull request within today.
|
It seems ok now. |
|
Thanks. Merged. |
No description provided.