Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(functionality): new method for list explorers by stack #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@ module.exports = {
"ecmaVersion": "latest"
},
"rules": {
"no-unused-vars": "off",
indent: ["error", 4],
"linebreak-style": ["error", "unix"],
quotes: ["error", "double"],
semi: ["error", "always"]
}
};
};
17 changes: 11 additions & 6 deletions lib/controllers/ExplorerController.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,30 @@ const ExplorerService = require("../services/ExplorerService");
const FizzbuzzService = require("../services/FizzbuzzService");
const Reader = require("../utils/reader");

class ExplorerController{
static getExplorersByMission(mission){
class ExplorerController {
static getExplorersByMission(mission) {
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.filterByMission(explorers, mission);
}

static applyFizzbuzz(score){
static applyFizzbuzz(score) {
return FizzbuzzService.applyValidationInNumber(score);
}

static getExplorersUsernamesByMission(mission){
static getExplorersUsernamesByMission(mission) {
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.getExplorersUsernamesByMission(explorers, mission);
}

static getExplorersAmonutByMission(mission){
static getExplorersAmonutByMission(mission) {
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.getAmountOfExplorersByMission(explorers, mission);
}

static getfilterByStack(stack) {
const explorers = Reader.readJsonFile("explorers.json");
return ExplorerService.filterByStack(explorers, stack);
}
}

module.exports = ExplorerController;
module.exports = ExplorerController;
17 changes: 11 additions & 6 deletions lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ app.use(express.json());
const port = 3000;

app.get("/", (request, response) => {
response.json({message: "FizzBuzz Api welcome!"});
response.json({ message: "FizzBuzz Api welcome!" });
});

app.get("/v1/explorers/:mission", (request, response) => {
Expand All @@ -17,22 +17,27 @@ app.get("/v1/explorers/:mission", (request, response) => {
app.get("/v1/explorers/amount/:mission", (request, response) => {
const mission = request.params.mission;
const explorersAmountInMission = ExplorerController.getExplorersAmonutByMission(mission);
response.json({mission: request.params.mission, quantity: explorersAmountInMission});
response.json({ mission: request.params.mission, quantity: explorersAmountInMission });
});

app.get("/v1/explorers/usernames/:mission", (request, response) => {
const mission = request.params.mission;
const explorersUsernames = ExplorerController.getExplorersUsernamesByMission(mission);
response.json({mission: request.params.mission, explorers: explorersUsernames});
response.json({ mission: request.params.mission, explorers: explorersUsernames });
});

app.get("/v1/fizzbuzz/:score", (request, response) => {
const score = parseInt(request.params.score);
const fizzbuzzTrick = ExplorerController.applyFizzbuzz(score);
response.json({score: score, trick: fizzbuzzTrick});
response.json({ score: score, trick: fizzbuzzTrick });
});

app.listen(port, () => {
console.log(`FizzBuzz API in localhost:${port}`);
app.get("/v1/explorers/stack/:stack", (request, response) => {
const stack = request.params.stack;
const explorersInStack = ExplorerController.getfilterByStack(stack);
response.json(explorersInStack);
});

app.listen(port, () => {
console.log(`FizzBuzz API in localhost:${port}`);
});
12 changes: 8 additions & 4 deletions lib/services/ExplorerService.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,25 @@
class ExplorerService {

static filterByMission(explorers, mission){
static filterByMission(explorers, mission) {
const explorersByMission = explorers.filter((explorer) => explorer.mission == mission);
return explorersByMission;
}

static getAmountOfExplorersByMission(explorers, mission){
static getAmountOfExplorersByMission(explorers, mission) {
const explorersByMission = ExplorerService.filterByMission(explorers, mission);
return explorersByMission.length;
}

static getExplorersUsernamesByMission(explorers, mission){
static getExplorersUsernamesByMission(explorers, mission) {
const explorersByMission = ExplorerService.filterByMission(explorers, mission);
const explorersUsernames = explorersByMission.map((explorer) => explorer.githubUsername);
return explorersUsernames;
}

static filterByStack(explorers, stack) {
const explorersByStack = explorers.filter((explorer) => explorer.stacks == stack);
return explorersByStack;
}
}

module.exports = ExplorerService;
module.exports = ExplorerService;
90 changes: 45 additions & 45 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "",
"license": "ISC",
"devDependencies": {
"eslint": "^8.14.0",
"eslint": "^8.15.0",
"jest": "^27.5.1"
},
"dependencies": {
Expand Down
9 changes: 7 additions & 2 deletions test/services/ExplorerService.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,14 @@ const ExplorerService = require("./../../lib/services/ExplorerService");

describe("Tests para ExplorerService", () => {
test("Requerimiento 1: Calcular todos los explorers en una misión", () => {
const explorers = [{mission: "node"}];
const explorers = [{ mission: "node" }];
const explorersInNode = ExplorerService.filterByMission(explorers, "node");
expect(explorersInNode.length).toBe(1);
});

});
test("Requerimiento 2: Devolver lista de explorers con ese stack", () => {
const explorers = [{ stacks: "javascript" }];
const explorersInStack = ExplorerService.filterByStack(explorers, "javascript");
expect(explorersInStack.length).toBe(1);
});
});