Add support for multiple response types to @paginate decorator
#1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
changed the title
@paginate decorator
|
This may be a duplicate of #1028 |
benjaoming
force-pushed
the
pagination-multiple-response-types
branch
from
7f04bcb
to
9b5adac
Compare
|
@pmdevita interesting that the approach was almost identical. |
|
Using updated I'm happy to add some tests from #1028 if this PR looks good to continue with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940
I won't have more time to work on this one :/ I was working on this for a prototype, suggesting to use django-ninja and I wanted to be able to give feedback about how easy it can be to add features to django-ninja that might still be missing, given that it's still a relatively new project. I found that the codebase was easy to navigate and find the right places to add the feature.
Would a more ninja-skilled developer be able to push this over the finish line?