Chore: Adding lint workflow and fixing format issues #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
reviewed
May 20, 2024
There was a problem hiding this comment.
Looks good to me, there are several warnings left by the new workflow in https://github.com/vitessio/arewefastyet/pull/545/files
|
Thank You @frouioui I have made the required changes, currently the workflow is failing since some files are not formatted and due to failing type checks. Looking forward to fix these in upcoming PRs. This one is ready to merge : ) |
|
Hello @DhairyaMajmudar, there are many conflicts, could you fix them before I merge this? |
Sure thing : ) |
|
Hi @frouioui I've resolved the conflicts and also fixed formatting issues in several newly added files. |
DhairyaMajmudar
changed the title
DhairyaMajmudar
changed the title
|
@frouioui @notfelineit a kind ping for PR review. |
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Dhairya Majmudar <124715224+DhairyaMajmudar@users.noreply.github.com>
Signed-off-by: Jad Chahed <jad.chahed@bashroom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks Done
package.jsonfor formatting the filesIssue Number:
#539
Screenshots/videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
Code files are now formatted