Skip to content

Commit

Permalink
mysqlctld: Remove unneeded resets in init_db.sql
Browse files Browse the repository at this point in the history
This removes the resets for the startup script that we use. These were
long ago added for a MariaDB 10.3 workaround which is not supported as a
managed tablet anyway anymore.

It also would only needed for an existing node to join a cluster that is
otherwise manually emptied. If that's the case, the reset should also be
done manually anyway too.

Removing this also ensures we have no logic here that would start
failing in the future on MySQL 8.4.0 which removed these statements.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
  • Loading branch information
dbussink committed May 2, 2024
1 parent cb624f5 commit 0abb087
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 12 deletions.
3 changes: 0 additions & 3 deletions config/init_db.sql
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ GRANT SELECT, PROCESS, SUPER, REPLICATION CLIENT, RELOAD
GRANT SELECT, UPDATE, DELETE, DROP
ON performance_schema.* TO 'vt_monitoring'@'localhost';

RESET SLAVE ALL;
RESET MASTER;

# custom sql is used to add custom scripts like creating users/passwords. We use it in our tests
# {{custom_sql}}

Expand Down
3 changes: 0 additions & 3 deletions examples/compose/config/init_db.sql
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ GRANT SELECT, INSERT, UPDATE, DELETE, CREATE, DROP, RELOAD, PROCESS, FILE,
SHOW VIEW, CREATE ROUTINE, ALTER ROUTINE, CREATE USER, EVENT, TRIGGER
ON *.* TO 'vt_filtered'@'localhost';

RESET SLAVE ALL;
RESET MASTER;

# custom sql is used to add custom scripts like creating users/passwords. We use it in our tests
# {{custom_sql}}

Expand Down
3 changes: 0 additions & 3 deletions examples/operator/101_initial_cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,6 @@ stringData:
SHOW VIEW, CREATE ROUTINE, ALTER ROUTINE, CREATE USER, EVENT, TRIGGER
ON *.* TO 'vt_filtered'@'localhost';
RESET SLAVE ALL;
RESET MASTER;
# custom sql is used to add custom scripts like creating users/passwords. We use it in our tests
# {{custom_sql}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,5 @@ GRANT SELECT, PROCESS, SUPER, REPLICATION CLIENT, RELOAD
GRANT SELECT, UPDATE, DELETE, DROP
ON performance_schema.* TO 'vt_monitoring'@'localhost';

RESET REPLICA ALL;
RESET MASTER;

# custom sql is used to add custom scripts like creating users/passwords. We use it in our tests
# {{custom_sql}}

0 comments on commit 0abb087

Please sign in to comment.