TabletServer: execute DDLs without timeout

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitessio · Sep 4, 2024 · 1004173 · 1004173
1 parent 1ed18d0
commit 1004173
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/go/vt/vttablet/tabletserver/tabletserver.go b/go/vt/vttablet/tabletserver/tabletserver.go
@@ -822,6 +822,10 @@ func (tsv *TabletServer) execute(ctx context.Context, target *querypb.Target, sq
  if err != nil {
  return err
  }
+ if plan.PlanID == planbuilder.PlanDDL {
+ // DDLs (especially ALTER TABLE, OPTIMIZE TABLE) can run for a very long time, so we don't want to enforce a specific timeout.
+ ctx = context.WithoutCancel(ctx)
+ }
  qre := &QueryExecutor{
  query: query,
  marginComments: comments,