Merge branch 'main' into mysqlshell-backup

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

MAINTAINERS.md

@@ -24,7 +24,7 @@ The following is the full list, alphabetically ordered.
 deepthi, mattlord, derekperkins
 
 ### Builds
-dkhenry, shlomi-noach, ajm188, vmg, GuptaManan100, frouioui
+shlomi-noach, ajm188, vmg, GuptaManan100, frouioui
 
 ### Resharding
 rohit-nayak-ps, deepthi, mattlord
@@ -54,7 +54,7 @@ deepthi, ajm188, GuptaManan100, dbussink
 harshit-gangal
 
 ### Kubernetes
-derekperkins, dkhenry, GuptaManan100, frouioui
+derekperkins, GuptaManan100, frouioui
 
 ### VTAdmin
 ajm188, notfelineit

changelog/21.0/21.0.0/summary.md

@@ -16,6 +16,7 @@
  - **[VTGate Tablet Balancer](#tablet-balancer)**
  - **[Query Timeout Override](#query-timeout)**
  - **[New Backup Engine](#new-backup-engine)**
+ - **[Dynamic VReplication Configuration](#dynamic-vreplication-configuration)**
 
 ## <a id="major-changes"/>Major Changes
 
@@ -132,9 +133,15 @@ A query can also be set to have no timeout by using the `QUERY_TIMEOUT_MS` comme
 Example usage:
 `select /*vt+ QUERY_TIMEOUT_MS=30 */ col from tbl`
 
-### <a id="new-backup-engine"/>New Backup Engine
+### <a id="new-backup-engine"/>New Backup Engine (EXPERIMENTAL)
 
 We are introducing a the backup engine supporting logical backups starting on v21 to support use cases that require something else besides physical backups. This is experimental and is based on the 
 [MySQL Shell](https://dev.mysql.com/doc/mysql-shell/8.0/en/).
 
 The new engine is enabled by using `--backup_engine_implementation=mysqlshell`. There are other options that are required, so check the docs on which options are required and how to use it.
+
+### <a id="dynamic-vreplication-configuration"/>Dynamic VReplication Configuration
+Currently many of the configuration options for VReplication Workflows are vttablet flags. This means that any change 
+requires restarts of vttablets. We now allow these to be overridden while creating a workflow or dynamically once
+the workflow is in progress. See https://github.com/vitessio/vitess/pull/16583 for details.
+

examples/common/scripts/vtadmin-up.sh

@@ -43,7 +43,7 @@ vtadmin \
  --alsologtostderr \
  --rbac \
  --rbac-config="${script_dir}/../vtadmin/rbac.yaml" \
- --cluster "id=${cluster_name},name=${cluster_name},discovery=staticfile,discovery-staticfile-path=${script_dir}/../vtadmin/discovery.json,tablet-fqdn-tmpl=http://{{ .Tablet.Hostname }}:15{{ .Tablet.Alias.Uid }}" \
+ --cluster "id=${cluster_name},name=${cluster_name},discovery=staticfile,discovery-staticfile-path=${script_dir}/../vtadmin/discovery.json,tablet-fqdn-tmpl=http://{{ .Tablet.Hostname }}:15{{ .Tablet.Alias.Uid }},schema-cache-default-expiration=1m" \
  > "${log_dir}/vtadmin-api.out" 2>&1 &
 
 vtadmin_api_pid=$!

examples/local/vstream_client.go

@@ -76,6 +76,7 @@ func main() {
  // MinimizeSkew: false,
  // HeartbeatInterval: 60, //seconds
  // StopOnReshard: true,
+ // IncludeReshardJournalEvents: true,
  }
  reader, err := conn.VStream(ctx, topodatapb.TabletType_PRIMARY, vgtid, filter, flags)
  if err != nil {

go.mod

@@ -10,11 +10,10 @@ require (
  github.com/HdrHistogram/hdrhistogram-go v0.9.0 // indirect
  github.com/aquarapid/vaultlib v0.5.1
  github.com/armon/go-metrics v0.4.1 // indirect
- github.com/aws/aws-sdk-go v1.55.5
  github.com/buger/jsonparser v1.1.1
  github.com/cespare/xxhash/v2 v2.3.0
  github.com/corpix/uarand v0.1.1 // indirect
- github.com/dave/jennifer v1.7.0
+ github.com/dave/jennifer v1.7.1
  github.com/evanphx/json-patch v5.9.0+incompatible
  github.com/fsnotify/fsnotify v1.7.0
  github.com/go-sql-driver/mysql v1.7.1
@@ -32,7 +31,6 @@ require (
  github.com/hashicorp/go-immutable-radix v1.3.1 // indirect
  github.com/hashicorp/serf v0.10.1 // indirect
  github.com/icrowley/fake v0.0.0-20180203215853-4178557ae428
- github.com/jmespath/go-jmespath v0.4.0 // indirect
  github.com/klauspost/compress v1.17.9
  github.com/klauspost/pgzip v1.2.6
  github.com/krishicks/yaml-patch v0.0.10
@@ -49,8 +47,8 @@ require (
  github.com/pkg/errors v0.9.1
  github.com/planetscale/pargzip v0.0.0-20201116224723-90c7fc03ea8a
  github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10
- github.com/prometheus/client_golang v1.20.2
- github.com/prometheus/common v0.57.0
+ github.com/prometheus/client_golang v1.20.3
+ github.com/prometheus/common v0.59.1
  github.com/sjmudd/stopwatch v0.1.1
  github.com/soheilhy/cmux v0.1.5
  github.com/spf13/cobra v1.8.1
@@ -59,31 +57,31 @@ require (
  github.com/stretchr/testify v1.9.0
  github.com/tchap/go-patricia v2.3.0+incompatible
  github.com/tidwall/gjson v1.17.3
- github.com/tinylib/msgp v1.2.0 // indirect
+ github.com/tinylib/msgp v1.2.1 // indirect
  github.com/uber/jaeger-client-go v2.30.0+incompatible
  github.com/uber/jaeger-lib v2.4.1+incompatible // indirect
  github.com/yudai/golcs v0.0.0-20170316035057-ecda9a501e82
  github.com/z-division/go-zookeeper v1.0.0
- go.etcd.io/etcd/api/v3 v3.5.15
- go.etcd.io/etcd/client/pkg/v3 v3.5.15
- go.etcd.io/etcd/client/v3 v3.5.15
+ go.etcd.io/etcd/api/v3 v3.5.16
+ go.etcd.io/etcd/client/pkg/v3 v3.5.16
+ go.etcd.io/etcd/client/v3 v3.5.16
  go.uber.org/mock v0.2.0
- golang.org/x/crypto v0.26.0 // indirect
- golang.org/x/mod v0.20.0 // indirect
- golang.org/x/net v0.28.0
- golang.org/x/oauth2 v0.22.0
- golang.org/x/sys v0.24.0
- golang.org/x/term v0.23.0
- golang.org/x/text v0.17.0 // indirect
+ golang.org/x/crypto v0.27.0 // indirect
+ golang.org/x/mod v0.21.0 // indirect
+ golang.org/x/net v0.29.0
+ golang.org/x/oauth2 v0.23.0
+ golang.org/x/sys v0.25.0
+ golang.org/x/term v0.24.0
+ golang.org/x/text v0.18.0 // indirect
  golang.org/x/time v0.6.0
- golang.org/x/tools v0.24.0
- google.golang.org/api v0.195.0
- google.golang.org/genproto v0.0.0-20240827150818-7e3bb234dfed // indirect
- google.golang.org/grpc v1.66.0
+ golang.org/x/tools v0.25.0
+ google.golang.org/api v0.197.0
+ google.golang.org/genproto v0.0.0-20240903143218-8af14fe29dc1 // indirect
+ google.golang.org/grpc v1.66.2
  google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
  google.golang.org/grpc/examples v0.0.0-20210430044426-28078834f35b
  google.golang.org/protobuf v1.34.2
- gopkg.in/DataDog/dd-trace-go.v1 v1.67.0
+ gopkg.in/DataDog/dd-trace-go.v1 v1.67.1
  gopkg.in/asn1-ber.v1 v1.0.0-20181015200546-f715ec2f112d // indirect
  gopkg.in/ldap.v2 v2.5.1
  sigs.k8s.io/yaml v1.4.0
@@ -92,6 +90,11 @@ require (
 require (
  github.com/DataDog/datadog-go/v5 v5.5.0
  github.com/Shopify/toxiproxy/v2 v2.9.0
+ github.com/aws/aws-sdk-go-v2 v1.30.4
+ github.com/aws/aws-sdk-go-v2/config v1.27.31
+ github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.15
+ github.com/aws/aws-sdk-go-v2/service/s3 v1.60.1
+ github.com/aws/smithy-go v1.20.4
  github.com/bndr/gotabulate v1.1.2
  github.com/gammazero/deque v0.2.1
  github.com/google/safehtml v0.1.0
@@ -104,26 +107,40 @@ require (
  github.com/spf13/jwalterweatherman v1.1.0
  github.com/xlab/treeprint v1.2.0
  go.uber.org/goleak v1.3.0
- golang.org/x/exp v0.0.0-20240823005443-9b4947da3948
+ golang.org/x/exp v0.0.0-20240909161429-701f63a606c0
  golang.org/x/sync v0.8.0
  gonum.org/v1/gonum v0.14.0
- modernc.org/sqlite v1.32.0
+ modernc.org/sqlite v1.33.1
 )
 
 require (
  cloud.google.com/go v0.115.1 // indirect
- cloud.google.com/go/auth v0.9.2 // indirect
+ cloud.google.com/go/auth v0.9.4 // indirect
  cloud.google.com/go/auth/oauth2adapt v0.2.4 // indirect
- cloud.google.com/go/compute/metadata v0.5.0 // indirect
- cloud.google.com/go/iam v1.2.0 // indirect
+ cloud.google.com/go/compute/metadata v0.5.1 // indirect
+ cloud.google.com/go/iam v1.2.1 // indirect
  github.com/DataDog/appsec-internal-go v1.7.0 // indirect
- github.com/DataDog/datadog-agent/pkg/obfuscate v0.56.1 // indirect
- github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.56.1 // indirect
- github.com/DataDog/go-libddwaf/v3 v3.3.0 // indirect
+ github.com/DataDog/datadog-agent/pkg/obfuscate v0.57.0 // indirect
+ github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.57.0 // indirect
+ github.com/DataDog/go-libddwaf/v3 v3.4.0 // indirect
  github.com/DataDog/go-sqllexer v0.0.14 // indirect
  github.com/DataDog/go-tuf v1.1.0-0.5.2 // indirect
  github.com/DataDog/sketches-go v1.4.6 // indirect
  github.com/Microsoft/go-winio v0.6.2 // indirect
+ github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.4 // indirect
+ github.com/aws/aws-sdk-go-v2/credentials v1.17.30 // indirect
+ github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.12 // indirect
+ github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.16 // indirect
+ github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.16 // indirect
+ github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
+ github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.16 // indirect
+ github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.4 // indirect
+ github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.3.18 // indirect
+ github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.18 // indirect
+ github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.17.16 // indirect
+ github.com/aws/aws-sdk-go-v2/service/sso v1.22.5 // indirect
+ github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.5 // indirect
+ github.com/aws/aws-sdk-go-v2/service/sts v1.30.5 // indirect
  github.com/beorn7/perks v1.0.1 // indirect
  github.com/coreos/go-semver v0.3.1 // indirect
  github.com/coreos/go-systemd/v22 v22.5.0 // indirect
@@ -138,7 +155,7 @@ require (
  github.com/gogo/protobuf v1.3.2 // indirect
  github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
  github.com/google/s2a-go v0.1.8 // indirect
- github.com/googleapis/enterprise-certificate-proxy v0.3.3 // indirect
+ github.com/googleapis/enterprise-certificate-proxy v0.3.4 // indirect
  github.com/googleapis/gax-go/v2 v2.13.0 // indirect
  github.com/hashicorp/errwrap v1.1.0 // indirect
  github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
@@ -176,17 +193,17 @@ require (
  github.com/tidwall/match v1.1.1 // indirect
  github.com/tidwall/pretty v1.2.1 // indirect
  go.opencensus.io v0.24.0 // indirect
- go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.54.0 // indirect
- go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.54.0 // indirect
- go.opentelemetry.io/otel v1.29.0 // indirect
- go.opentelemetry.io/otel/metric v1.29.0 // indirect
- go.opentelemetry.io/otel/trace v1.29.0 // indirect
+ go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.55.0 // indirect
+ go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.55.0 // indirect
+ go.opentelemetry.io/otel v1.30.0 // indirect
+ go.opentelemetry.io/otel/metric v1.30.0 // indirect
+ go.opentelemetry.io/otel/trace v1.30.0 // indirect
  go.uber.org/atomic v1.11.0 // indirect
  go.uber.org/multierr v1.11.0 // indirect
  go.uber.org/zap v1.27.0 // indirect
- golang.org/x/xerrors v0.0.0-20240716161551-93cc26a95ae9 // indirect
- google.golang.org/genproto/googleapis/api v0.0.0-20240827150818-7e3bb234dfed // indirect
- google.golang.org/genproto/googleapis/rpc v0.0.0-20240827150818-7e3bb234dfed // indirect
+ golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da // indirect
+ google.golang.org/genproto/googleapis/api v0.0.0-20240903143218-8af14fe29dc1 // indirect
+ google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 // indirect
  gopkg.in/ini.v1 v1.67.0 // indirect
  gopkg.in/yaml.v2 v2.4.0 // indirect
  gopkg.in/yaml.v3 v3.0.1 // indirect