Skip to content

Commit

Permalink
feat: deprecated vreplication flag deletion
Browse files Browse the repository at this point in the history
Signed-off-by: Manan Gupta <manan@planetscale.com>
  • Loading branch information
GuptaManan100 committed May 7, 2024
1 parent 9bfc18c commit 1dbee32
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 5 additions & 0 deletions changelog/20.0/20.0.0/summary.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- **[Major Changes](#major-changes)**
- **[Deletions](#deletions)**
- [`--vreplication_tablet_type` flag is now deleted](#vreplication-tablet-type-deletion)
- [`Pool Capacity Flags Deletion`](#pool-flags-deletion)
- [MySQL binaries in the vitess/lite Docker images](#vitess-lite)
- [vitess/base and vitess/k8s Docker images](#base-k8s-images)
Expand Down Expand Up @@ -41,6 +42,10 @@

### <a id="deletions"/>Deletion

#### <a id="vreplication-tablet-type-deletion"\>`--vreplication_tablet_type` flag is now deleted

The previously deprecated flags `--vreplication_tablet_type` has been deleted.

#### <a id="pool-flags-deletion"/>Pool Capacity Flags Deletion

The previously deprecated flags `--queryserver-config-query-pool-waiter-cap`, `--queryserver-config-stream-pool-waiter-cap` and `--queryserver-config-txpool-waiter-cap` have been deleted.
Expand Down
4 changes: 0 additions & 4 deletions go/vt/vttablet/tabletmanager/vreplication/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ func registerVReplicationFlags(fs *pflag.FlagSet) {
fs.BoolVar(&vreplicationStoreCompressedGTID, "vreplication_store_compressed_gtid", vreplicationStoreCompressedGTID, "Store compressed gtids in the pos column of the sidecar database's vreplication table")

fs.IntVar(&vreplicationParallelInsertWorkers, "vreplication-parallel-insert-workers", vreplicationParallelInsertWorkers, "Number of parallel insertion workers to use during copy phase. Set <= 1 to disable parallelism, or > 1 to enable concurrent insertion during copy phase.")

// Deprecated and ignored in v19.
fs.String("vreplication_tablet_type", tabletTypesStr, "Comma-separated list of tablet types used as a source.")
fs.MarkDeprecated("vreplication_tablet_type", "As of v19 this is ignored and will be removed in a future release.")
}

func init() {
Expand Down

0 comments on commit 1dbee32

Please sign in to comment.