Remove loopclosure captures from tests (#15202)

Signed-off-by: William Huang <mail.william.huang@gmail.com>
vitessio · Feb 12, 2024 · 34acc9c · 34acc9c
1 parent cd61d85
commit 34acc9c
Show file tree

Hide file tree

Showing 35 changed files with 0 additions and 256 deletions.
diff --git a/go/flagutil/enum_test.go b/go/flagutil/enum_test.go
@@ -56,7 +56,6 @@ func TestStringEnum(t *testing.T) {
  },
  }
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  var enum *StringEnum
  if tt.caseInsensitive {

diff --git a/go/protoutil/duration_test.go b/go/protoutil/duration_test.go
@@ -81,8 +81,6 @@ func TestDurationFromProto(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
 
  actual, ok, err := DurationFromProto(tt.in)
@@ -124,8 +122,6 @@ func TestDurationToProto(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
 
  actual := DurationToProto(tt.in)

diff --git a/go/vt/callinfo/callinfo_test.go b/go/vt/callinfo/callinfo_test.go
@@ -55,7 +55,6 @@ func TestNewContext(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  require.Equal(t, tt.expectedContext, NewContext(tt.ctx, tt.ci))
  })
@@ -84,7 +83,6 @@ func TestFromContext(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  ci, ok := FromContext(tt.ctx)
  require.Equal(t, tt.expectedCi, ci)
@@ -112,7 +110,6 @@ func TestHTMLFromContext(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  require.Equal(t, tt.expectedHTML, HTMLFromContext(tt.ctx))
  })

diff --git a/go/vt/logz/logz_utils_test.go b/go/vt/logz/logz_utils_test.go
@@ -45,7 +45,6 @@ func TestWrappable(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.input, func(t *testing.T) {
  require.Equal(t, tt.output, Wrappable(tt.input))
  })

diff --git a/go/vt/topo/topotests/cell_info_test.go b/go/vt/topo/topotests/cell_info_test.go
@@ -217,7 +217,6 @@ func TestExpandCells(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  expanded, err := ts.ExpandCells(ctx, tt.in)
  if tt.shouldErr {

diff --git a/go/vt/vtadmin/api_test.go b/go/vt/vtadmin/api_test.go
@@ -547,8 +547,6 @@ func TestFindSchema(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -862,8 +860,6 @@ func TestGetClusters(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1052,8 +1048,6 @@ func TestGetKeyspace(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1284,8 +1278,6 @@ func TestGetKeyspaces(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1538,8 +1530,6 @@ func TestGetSchema(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  ctx, cancel := context.WithCancel(context.Background())
@@ -2179,8 +2169,6 @@ func TestGetSchemas(t *testing.T) {
  // Note that these test cases were written prior to the existence of
  // WithTestServers, so they are all written with the assumption that
  // there are exactly 2 clusters.
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  ctx, cancel := context.WithCancel(context.Background())
@@ -2626,8 +2614,6 @@ func TestGetSrvKeyspace(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -2787,8 +2773,6 @@ func TestGetSrvKeyspaces(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  ctx, cancel := context.WithCancel(context.Background())
@@ -2956,8 +2940,6 @@ func TestGetSrvVSchema(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  ctx, cancel := context.WithCancel(context.Background())
@@ -3250,8 +3232,6 @@ func TestGetSrvVSchemas(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
  ctx, cancel := context.WithCancel(context.Background())
@@ -3531,8 +3511,6 @@ func TestGetTablet(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -3726,8 +3704,6 @@ func TestGetTablets(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -3872,8 +3848,6 @@ func TestGetVSchema(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -4198,8 +4172,6 @@ func TestGetVSchemas(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -4419,8 +4391,6 @@ func TestGetWorkflow(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -4858,8 +4828,6 @@ func TestGetWorkflows(t *testing.T) {
  ctx := context.Background()
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -5099,8 +5067,6 @@ func TestVTExplain(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  ctx, cancel := context.WithCancel(context.Background())
  defer cancel()
@@ -5350,8 +5316,6 @@ func TestServeHTTP(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 

diff --git a/go/vt/vtadmin/cache/cache_test.go b/go/vt/vtadmin/cache/cache_test.go
@@ -67,7 +67,6 @@ func TestBackfillDuplicates(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -131,7 +130,6 @@ func TestBackfillTTL(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 

diff --git a/go/vt/vtadmin/cache/refresh_test.go b/go/vt/vtadmin/cache/refresh_test.go
@@ -65,7 +65,6 @@ func TestShouldRefreshFromIncomingContext(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -114,7 +113,6 @@ func TestShouldRefreshFromRequest(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 

diff --git a/go/vt/vtadmin/cluster/cluster_internal_test.go b/go/vt/vtadmin/cluster/cluster_internal_test.go
@@ -142,8 +142,6 @@ func TestDeleteTablets(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -331,8 +329,6 @@ func TestEmergencyFailoverShard(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -493,8 +489,6 @@ func Test_getShardSets(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -662,8 +656,6 @@ func TestPlannedFailoverShard(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -775,8 +767,6 @@ func TestRefreshState(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -899,8 +889,6 @@ func TestRefreshTabletReplicationSource(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1189,8 +1177,6 @@ func Test_reloadKeyspaceSchemas(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1516,8 +1502,6 @@ func Test_reloadShardSchemas(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1700,8 +1684,6 @@ func Test_reloadTabletSchemas(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()
 
@@ -1903,8 +1885,6 @@ func TestTabletExternallyPromoted(t *testing.T) {
  }
 
  for _, tt := range tests {
- tt := tt
-
  t.Run(tt.name, func(t *testing.T) {
  t.Parallel()