Skip to content

Commit

Permalink
Cherry-pick 888df92 with conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
vitess-bot[bot] committed Jul 18, 2023
1 parent f4598d5 commit 4643320
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 0 deletions.
6 changes: 6 additions & 0 deletions go/test/endtoend/vtorc/primaryfailure/primary_failure_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,25 @@ func TestDownPrimary(t *testing.T) {
defer cluster.PanicHandler(t)
<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
utils.SetupVttabletsAndVTOrcs(t, clusterInfo, 2, 1, nil, cluster.VTOrcConfiguration{
=======
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
// We specify the --wait-replicas-timeout to a small value because we spawn a cross-cell replica later in the test.
// If that replica is more advanced than the same-cell-replica, then we try to promote the cross-cell replica as an intermediate source.
// If we don't specify a small value of --wait-replicas-timeout, then we would end up waiting for 30 seconds for the dead-primary to respond, failing this test.
utils.SetupVttabletsAndVTOrcs(t, clusterInfo, 2, 1, []string{"--remote_operation_timeout=10s", "--wait-replicas-timeout=5s"}, cluster.VTOrcConfiguration{
<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
Expand Down
3 changes: 3 additions & 0 deletions go/test/endtoend/vtorc/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,9 @@ func PrintVTOrcLogsOnFailure(t *testing.T, clusterInstance *cluster.LocalProcess
}
<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
Expand Down
3 changes: 3 additions & 0 deletions go/vt/vtorc/inst/instance_dao.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ func initializeInstanceDao() {
cacheInitializationCompleted.Store(true)
<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
Expand Down
3 changes: 3 additions & 0 deletions go/vt/vtorc/inst/instance_dao_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,9 @@ func waitForCacheInitialization() {
}
<<<<<<< HEAD
<<<<<<< HEAD
<<<<<<< HEAD
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
=======
>>>>>>> 888df9228e (Fix flakiness in VTOrc tests (#13489))
Expand Down

0 comments on commit 4643320

Please sign in to comment.