fix: remove keyspace when merging subqueries (#16019)

Signed-off-by: Andres Taylor <andres@planetscale.com>
vitessio · May 29, 2024 · 5480dd1 · 5480dd1
1 parent 6bfdccf
commit 5480dd1
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/go/vt/vtgate/planbuilder/operators/subquery_planning.go b/go/vt/vtgate/planbuilder/operators/subquery_planning.go
@@ -467,6 +467,7 @@ func tryMergeSubqueryWithOuter(ctx *plancontext.PlanningContext, subQuery *SubQu
  return outer, NoRewrite
  }
  exprs := subQuery.GetMergePredicates()
+ sqlparser.RemoveKeyspace(subQuery.Original)
  merger := &subqueryRouteMerger{
  outer: outer,
  original: subQuery.Original,

diff --git a/go/vt/vtgate/planbuilder/testdata/filter_cases.json b/go/vt/vtgate/planbuilder/testdata/filter_cases.json
@@ -870,6 +870,29 @@
  ]
  }
  },
+ {
+ "comment": "Merging subqueries should remove keyspace from query",
+ "query": "select u.id from user.user as u where not exists (select 1 from user.user_extra as ue where u.id = ue.user_id)",
+ "plan": {
+ "QueryType": "SELECT",
+ "Original": "select u.id from user.user as u where not exists (select 1 from user.user_extra as ue where u.id = ue.user_id)",
+ "Instructions": {
+ "OperatorType": "Route",
+ "Variant": "Scatter",
+ "Keyspace": {
+ "Name": "user",
+ "Sharded": true
+ },
+ "FieldQuery": "select u.id from `user` as u where 1 != 1",
+ "Query": "select u.id from `user` as u where not exists (select 1 from user_extra as ue where u.id = ue.user_id)",
+ "Table": "`user`"
+ },
+ "TablesUsed": [
+ "user.user",
+ "user.user_extra"
+ ]
+ }
+ },
  {
  "comment": "Single table equality route with unsigned value",
  "query": "select id from user where name = 18446744073709551615",