Ensure that WithParams keeps the transport (#15421)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
vitessio · Mar 7, 2024 · 66f1990 · 66f1990
1 parent 6c73053
commit 66f1990
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/go/vt/mysqlctl/s3backupstorage/s3.go b/go/vt/mysqlctl/s3backupstorage/s3.go
@@ -435,7 +435,7 @@ func (bs *S3BackupStorage) Close() error {
 }
 
 func (bs *S3BackupStorage) WithParams(params backupstorage.Params) backupstorage.BackupStorage {
-	return &S3BackupStorage{params: params}
+	return &S3BackupStorage{params: params, transport: bs.transport}
 }
 
 var _ backupstorage.BackupStorage = (*S3BackupStorage)(nil)

diff --git a/go/vt/mysqlctl/s3backupstorage/s3_test.go b/go/vt/mysqlctl/s3backupstorage/s3_test.go
@@ -286,3 +286,13 @@ func TestNewS3Transport(t *testing.T) {
 	assert.NotNil(t, s3.transport.DialContext)
 	assert.NotNil(t, s3.transport.Proxy)
 }
+
+func TestWithParams(t *testing.T) {
+	bases3 := newS3BackupStorage()
+	s3 := bases3.WithParams(backupstorage.Params{}).(*S3BackupStorage)
+	// checking some of the values are present in the returned transport and match the http.DefaultTransport.
+	assert.Equal(t, http.DefaultTransport.(*http.Transport).IdleConnTimeout, s3.transport.IdleConnTimeout)
+	assert.Equal(t, http.DefaultTransport.(*http.Transport).MaxIdleConns, s3.transport.MaxIdleConns)
+	assert.NotNil(t, s3.transport.DialContext)
+	assert.NotNil(t, s3.transport.Proxy)
+}