Workflow Delete: remove workflow before artifacts

Otherwise the cancel/delete and cleanup work can fail.

Signed-off-by: Matt Lord <mattalord@gmail.com>

go/vt/vtctl/workflow/server.go

@@ -1970,14 +1970,6 @@ func (s *Server) WorkflowDelete(ctx context.Context, req *vtctldatapb.WorkflowDe
  span.Annotate("keep_routing_rules", req.KeepRoutingRules)
  span.Annotate("shards", req.Shards)
 
- // Cleanup related data and artifacts.
- if _, err := s.DropTargets(ctx, req.Keyspace, req.Workflow, req.KeepData, req.KeepRoutingRules, false); err != nil {
- if topo.IsErrType(err, topo.NoNode) {
- return nil, vterrors.Wrapf(err, "%s keyspace does not exist", req.Keyspace)
- }
- return nil, err
- }
-
  deleteReq := &tabletmanagerdatapb.DeleteVReplicationWorkflowRequest{
  Workflow: req.Workflow,
  }
@@ -2002,6 +1994,14 @@ func (s *Server) WorkflowDelete(ctx context.Context, req *vtctldatapb.WorkflowDe
  return nil, vterrors.Errorf(vtrpcpb.Code_FAILED_PRECONDITION, "the %s workflow does not exist in the %s keyspace", req.Workflow, req.Keyspace)
  }
 
+ // Cleanup related data and artifacts.
+ if _, err := s.DropTargets(ctx, req.Keyspace, req.Workflow, req.KeepData, req.KeepRoutingRules, false); err != nil {
+ if topo.IsErrType(err, topo.NoNode) {
+ return nil, vterrors.Wrapf(err, "%s keyspace does not exist", req.Keyspace)
+ }
+ return nil, err
+ }
+
  response := &vtctldatapb.WorkflowDeleteResponse{}
  response.Summary = fmt.Sprintf("Successfully cancelled the %s workflow in the %s keyspace", req.Workflow, req.Keyspace)
  details := make([]*vtctldatapb.WorkflowDeleteResponse_TabletInfo, 0, len(res))