schemadiff: consistent key ordering in table diff (#17141)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vitessio · Nov 5, 2024 · a9bab82 · a9bab82
1 parent 9ed8ee2
commit a9bab82
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 5 deletions.
diff --git a/go/vt/schemadiff/schema_diff.go b/go/vt/schemadiff/schema_diff.go
@@ -280,8 +280,8 @@ func (d *SchemaDiff) UnorderedDiffs() []EntityDiff {
 	return d.diffs
 }
 
-// AllDependenciess returns all known dependencies
-func (d *SchemaDiff) AllDependenciess() (deps []*DiffDependency) {
+// AllDependencies returns all known dependencies
+func (d *SchemaDiff) AllDependencies() (deps []*DiffDependency) {
 	for _, dep := range d.dependencies {
 		deps = append(deps, dep)
 	}

diff --git a/go/vt/schemadiff/schema_diff_test.go b/go/vt/schemadiff/schema_diff_test.go
@@ -1272,7 +1272,7 @@ func TestSchemaDiff(t *testing.T) {
 			}
 			assert.Equalf(t, tc.expectDiffs, len(allDiffs), "found diffs: %v", allDiffsStatements)
 
-			deps := schemaDiff.AllDependenciess()
+			deps := schemaDiff.AllDependencies()
 			depsKeys := []string{}
 			for _, dep := range deps {
 				depsKeys = append(depsKeys, dep.hashKey())

diff --git a/go/vt/schemadiff/table.go b/go/vt/schemadiff/table.go
@@ -1711,8 +1711,10 @@ func (c *CreateTableEntity) diffKeys(alterTable *sqlparser.AlterTable,
 			}
 		}
 	}
-	for _, stmt := range dropKeyStatements {
-		alterTable.AlterOptions = append(alterTable.AlterOptions, stmt)
+	for _, t1Key := range t1Keys {
+		if stmt, ok := dropKeyStatements[t1Key.Info.Name.String()]; ok {
+			alterTable.AlterOptions = append(alterTable.AlterOptions, stmt)
+		}
 	}
 	return superfluousFulltextKeys
 }

diff --git a/go/vt/schemadiff/table_test.go b/go/vt/schemadiff/table_test.go
@@ -733,6 +733,24 @@ func TestCreateTableDiff(t *testing.T) {
 				"-	KEY `i_idx` (`i`)",
 			},
 		},
+		{
+			name:  "multiple dropped keys and columns",
+			from:  "create table t1 (`id` int, i1 int, i2 int, i3 int, primary key (id), key k1(i1), key k2(i2), key k3(i1), key k4(i2), key k5(i1), key k6(i2))",
+			to:    "create table t1 (`id` int, primary key (id))",
+			diff:  "alter table t1 drop key k1, drop key k2, drop key k3, drop key k4, drop key k5, drop key k6, drop column i1, drop column i2, drop column i3",
+			cdiff: "ALTER TABLE `t1` DROP KEY `k1`, DROP KEY `k2`, DROP KEY `k3`, DROP KEY `k4`, DROP KEY `k5`, DROP KEY `k6`, DROP COLUMN `i1`, DROP COLUMN `i2`, DROP COLUMN `i3`",
+			textdiffs: []string{
+				"-	KEY `k1` (`i1`)",
+				"-	KEY `k2` (`i2`)",
+				"-	KEY `k3` (`i1`)",
+				"-	KEY `k4` (`i2`)",
+				"-	KEY `k5` (`i1`)",
+				"-	KEY `k6` (`i2`)",
+				"-	`i1` int,",
+				"-	`i2` int,",
+				"-	`i3` int,",
+			},
+		},
 		{
 			name:  "modified key",
 			from:  "create table t1 (`id` int primary key, i int, key i_idx(i))",